Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust header text size for mobile and tablet #1706

Merged
merged 1 commit into from
Jun 11, 2021
Merged

adjust header text size for mobile and tablet #1706

merged 1 commit into from
Jun 11, 2021

Conversation

paulsvh
Copy link
Contributor

@paulsvh paulsvh commented Jun 11, 2021

Fixes #1599

  • Changed size of site map header text from 24px to 32px in mobile sizes:
    Before:

issue1559_mobile_before

After:

issue1559_mobile_after

  • Changed size of site map header text from 48px to 40px in tablet sizes:
    Before:

issue1559_tablet_before

After:

issue1559_tablet_after

akibrhast
akibrhast approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@akibrhast akibrhast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akibrhast akibrhast merged commit 7479c4a into hackforla:gh-pages Jun 11, 2021
@Aveline-art
Copy link
Member

@akibrhast Do we need a second reviewer before merging?

@qiqicodes
Copy link
Member

@Aveline-art yes, we should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akibrhast akibrhast akibrhast approved these changes

@qiqicodes qiqicodes Awaiting requested review from qiqicodes

@jbubar jbubar Awaiting requested review from jbubar

@Aveline-art Aveline-art Awaiting requested review from Aveline-art

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase the font size of the Sitemap page heading in mobile and tablet
4 participants
@paulsvh @Aveline-art @qiqicodes @akibrhast