Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage header #1364

Merged
merged 7 commits into from
Apr 8, 2021

Conversation

Lol-Whut
Copy link
Member

@Lol-Whut Lol-Whut commented Apr 7, 2021

Fixes #1202

We needed to update the header of the home page to ensure that it is clear to people visiting the site that all events are remote and make sure that the "Get Started" button is visible above the fold.

-Updated the text to match new wording
-Added separate "p" tags and adjusted margins of "h1" and "p" tags to better reflect Figma spacing
-Used a "span" around the word "remote" and styled it to add the dark pink underline (Note: we could make this a class if we want to make it reusable. Also, ended up going with "span" instead of "u" because the automatic spacing between the word "remote" and the underline was more attractive and compliant with the Figma file using )
-Adjusted the height of the hero image from 140vh to 80vh, which ensures that it doesn't take up the entire screen, thus allowing room for the button at the bottom of the screen.
-Commented out any non-remote Locations on the markdown files for each project so that they will not show up in the Locations menu.

Old:

image

image

With Changes:

image

image

@erikaBell
Copy link
Member

Just reviewed Lara's pull request, the changes she made does not break the events page 'our locations'.

Events Pg

image

Copy link
Member

@akibrhast akibrhast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akibrhast akibrhast merged commit 41c73cd into hackforla:gh-pages Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update homepage header - all meetings are remote
3 participants