Fix hamburger menu #1344
Merged
Fix hamburger menu #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbubar
reviewed
Mar 31, 2021
_sass/components/_calendar.scss
Outdated
| @@ -67,7 +67,7 @@ button { | |||
| margin: 5px 0; | |||
|
|
|||
| &:hover { | |||
| background: $color-red; | |||
| // background: $color-red; | |||
There was a problem hiding this comment.
Nice job here. I'd like to recommend to delete this whole &:hover section. then check and see if it messes up any buttons. I do not think it will.
|
@jbubar I removed the &:hover section and verified that there are no critical errors! |
martham0
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented line in _calendar.scss that creates the bug for the hamburger menu on mobile. Did not want to delete things and cause more problems. Discussed issue with developer team and they stated that _calendar.scss is not being currently used. Fixes #1258.