Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated donation gif on Join Us page #1316

Merged

Conversation

kevinreber
Copy link
Contributor

Fixes #1254

Removed /assets/images/join-us/HfLA-Donate.gif and replaced it with /assets/images/about/HFLA-Donate.gif

Before

image

After

image

@qiqicodes qiqicodes self-requested a review March 24, 2021 02:52
Copy link
Member

@qiqicodes qiqicodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gif looks good cropped. This is what the gif looks like in VS Code.

HFLA-donate.gif.mov

On my localhost, I can't load any of the images on the about page.
is there an existing issue that address this issue?

Images.not.showing.on.about.page.mov

The terminal shows error for accessing the files.

Errors.in.terminal.mov

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.. Sorry about the git stuff qiqi

@jbubar jbubar merged commit df836e6 into hackforla:gh-pages Mar 24, 2021
@kevinreber kevinreber deleted the 1254-Join-Us-Update-donation-gif branch March 24, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update donation gif on Join Us page
3 participants