Standardizing wins page #1204
Standardizing wins page #1204
Conversation
Get latest code to evancchen/website
Update code
Update code
Update code from hackforla to evancchen
Update code
Update code
Update code
Update code
Update code
Update code
Update code
Update code
Update code
|
It looks like element nesting got shuffled around a little bit during edits. When I pulled the branch to my machine and accepted incoming changes, I got syntactical error warnings for the curly braces on lines 56 and 87, and styling changes did not show up for me in the browser. @akibrhast are you seeing the same, or is this on my end? For reference, right here it looks like there's an extra curly brace: |
There was a problem hiding this comment.
- Please fix the merge conflicts.
- Please ensures scss nests are properly nested and you can build the changes locally after addressing the merge conflicts
This is what I am seeing on my end when I try to build with docker-compose up
hfla_site | jekyll 3.9.0 | Error: Invalid CSS after "...b67d488000a5e71": expected "{", was "}" on line 59
hfla_site | Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/main.scss':
hfla_site | Invalid CSS after "...b67d488000a5e71": expected "{", was "}" on line 59
hfla_site | /usr/gem/gems/jekyll-sass-converter-1.5.2/lib/jekyll/converters/scss.rb:123:in `rescue in convert': Invalid CSS after "...b67d488000a5e71": expected
"{", was "}" on line 59 (Jekyll::Converters::Scss::SyntaxError)
|
@Lol-Whut It seems like @evancchen has updated the PR since our last review. Please re-review this and approve his changes if everything looks good , and nothing breaks. |
|
This is definitely looking better! No merge problems, the h1 tag is giving the "Let's Celebrate Together!" its styling and the margin-bottom is now 56px. However, it looks like the max-height of the .wins-hero img class still needs to be adjusted to 360px and the color of .wins_see-more-div still needs to be adjusted to $color-red. I think once those changes are in, it'll be perfect! I think we should be seeing those two changes in these areas: |
There was a problem hiding this comment.
I think once the max-height and color changes I mentioned in my most recent comment are made, we'll be good to go! @evancchen
_sass/components/_wins-page.scss
Outdated
| @@ -6,14 +6,10 @@ | |||
| align-items: center; | |||
| justify-content: space-evenly; | |||
| img{ | |||
| height: 366; | |||
| height: 360px; | |||
There was a problem hiding this comment.
change this to max-height and it'll be perf!
|
Looks good to me! |
Fixes #1166