Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

959 toolkit banner links #1199

Merged
merged 10 commits into from
Mar 14, 2021
Merged

959 toolkit banner links #1199

merged 10 commits into from
Mar 14, 2021

Conversation

akibrhast
Copy link
Member

Closes #959

@akibrhast akibrhast requested review from jbubar and drubgrubby March 12, 2021 20:35
drubgrubby
drubgrubby approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@drubgrubby drubgrubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcspach @akibrhast - Nice work on these links/filters. All seems good to me.

@jbubar
Copy link
Member

jbubar commented Mar 13, 2021

Looks great... I just noticed one inconsistency.
If you click on "All", "Development", or "Design" it has a slightly different behavior than clicking on "Project Management", and "Project Development"

jbubar
jbubar requested changes Mar 13, 2021
View reviewed changes
Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look over this one line?
line 20 in toolkit.html
It is inconsistent.
Personally, I would prefer if it did not redirect, as in I prefer the behavior of Project Management, and Professional Development rather than All, Development, Design

toolkit.html Outdated Show resolved Hide resolved
@jbubar jbubar merged commit 203bccb into hackforla:gh-pages Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbubar jbubar jbubar requested changes

@drubgrubby drubgrubby drubgrubby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the Toolkit page's category-filtering banner functional
4 participants
@akibrhast @jbubar @drubgrubby @mcspach