-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change background #1172
Change background #1172
Conversation
Get latest code to evancchen/website
Update code
Update code
Update code from hackforla to evancchen
Update code
Update code
Update code
Update code
Update code
Update code
Update code
Update code
Update code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the colors are using the right sass variable and not hardcoded colors
_sass/components/_events.scss
Outdated
@@ -510,7 +510,7 @@ | |||
|
|||
|
|||
.events-page{ | |||
background: #030c2c; | |||
background: #030d2d; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hardcoding the color #0302d
, could you please ensure to use the variable provided.
$color-blue-dark
@@ -9,7 +9,7 @@ | |||
} | |||
|
|||
.getting-started-page { | |||
background: #030c2c; | |||
background: #030d2d; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hardcoding the color #0302d
, could you please ensure to use the variable provided.
$color-blue-dark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Fixes #1169
Changed background color from #030c2c to #030d2d in events page and getting started page.