Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change background #1172

Merged
merged 16 commits into from
Mar 9, 2021
Merged

Change background #1172

merged 16 commits into from
Mar 9, 2021

Conversation

evancchen
Copy link
Contributor

Fixes #1169
Changed background color from #030c2c to #030d2d in events page and getting started page.

Copy link
Member

@akibrhast akibrhast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the colors are using the right sass variable and not hardcoded colors

@@ -510,7 +510,7 @@


.events-page{
background: #030c2c;
background: #030d2d;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding the color #0302d , could you please ensure to use the variable provided.
$color-blue-dark

@@ -9,7 +9,7 @@
}

.getting-started-page {
background: #030c2c;
background: #030d2d;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding the color #0302d , could you please ensure to use the variable provided.
$color-blue-dark

@evancchen evancchen requested a review from akibrhast March 9, 2021 15:43
Copy link
Member

@akibrhast akibrhast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@akibrhast akibrhast merged commit 05be3f0 into hackforla:gh-pages Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize dark background color on Events and Getting Started pages
2 participants