Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styling #1148

Merged
merged 15 commits into from
Mar 3, 2021
Merged

Conversation

evancchen
Copy link
Contributor

Fixes #1136

@qiqicodes qiqicodes requested review from qiqicodes and akibrhast March 2, 2021 05:49
Copy link
Member

@qiqicodes qiqicodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the inline styling issue caused the h1 of header-container-content.html styling to have #ffffff. And currently it is invisible unless highlighted.
Screen Shot 2021-03-01 at 10 14 46 PM
Screen Shot 2021-03-01 at 10 15 00 PM

I suggest inline color styling for the h1 of header-container-content.html.

@daniellex0
Copy link
Member

daniellex0 commented Mar 2, 2021

@akibrhast @qiqicodes @evancchen Sorry I probably should have been more specific in the issue- this definitely shouldn't be a generic h1 class. There should be a specific new class name attached to both "Our Events" and "Our Locations" h1 tags. Something like .events-subheadings or whatever you think would be most appropriate. And the properties should be listed under that new class on the _events.scss file. Or as Akib said, these h1 properties can be nested under .events-page. Whatever you guys think is preferable. But this definitely shouldn't be a new styling that will be connected to all h1 tags across the site and turn them all white!

Also are there supposed to be 14 commits on this pull request? This may relate to checking out back to the gh-pages branch after pushing a branch. We used to have this issue a lot before we added extra emphasis about this in the readme. We can discuss at today's dev meeting..

@evancchen evancchen requested review from qiqicodes and akibrhast March 3, 2021 03:28
@akibrhast akibrhast merged commit 6c32862 into hackforla:gh-pages Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Events Page: Remove all HTML inline styling
4 participants