Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wins badges #1006

Closed
wants to merge 6 commits into from
Closed

Wins badges #1006

wants to merge 6 commits into from

Conversation

jbubar
Copy link
Member

@jbubar jbubar commented Feb 7, 2021

This pr reworks the wins page to make it look cleaner and also adds the badges on the overlay
#162

@jbubar jbubar requested a review from daniellex0 February 7, 2021 10:56
@jbubar
Copy link
Member Author

jbubar commented Feb 7, 2021

the number of columns change based on the width of screen. The css is not perfect, I probably need to consult our local css grid heavy weight @drubgrubby.
Also.. I made the modal scroll if it is too tall for the screen, it would be great to get feedback on that behavior.

Screen Shot 2021-02-07 at 2 58 33 AM
Screen Shot 2021-02-07 at 2 58 57 AM

@jbubar
Copy link
Member Author

jbubar commented Feb 9, 2021

Spoke to bonnie, danielle and oskar, and they requested that I make some changes to the mobile view and change the styling for the overlay a bit

@jbubar jbubar removed the request for review from daniellex0 February 10, 2021 04:37
@jbubar jbubar closed this Feb 14, 2021
@jbubar jbubar mentioned this pull request Mar 14, 2021
4 tasks
@daniellex0 daniellex0 mentioned this pull request Apr 18, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant