Join us page #1002

trtincher · 2021-02-04T17:06:02Z

This is the new join us page. Access with "localhost:4000/join-us".
This corresponds to issue: #752 (this does not close the issue)
All layouts and styling are in compliance with the Figma

Desktop

Mobile

…Join-Us-Page

update to match upstream

dmcneary

Mobile view looks good! I see a couple of typos:

h1 text in the first card ('Advice' vs 'Advise')
some typos in that card's body text
top/bottom margins between the buttons in the third card (Partner with us) narrower compared to Figma mock
top/bottom margins between cards are narrower compared to Figma mock
'hero' element in desktop view could probably be moved up towards the main nav a bit

daniellex0

This page is looking great, it's really close! I added my notes about changes in the Figma file, to the right of the notes from before: https://www.figma.com/file/0RRPy1Ph7HafI3qOITg0Mr/Hack-for-LA-Website?node-id=2991%3A0

akibrhast · 2021-02-22T17:51:18Z

@trtincher Couple of things I have noticed:

Almost all the new files created under _credits in this commit has spaces in their filename. Maybe do something like this for example: _credits/building-2.md . Since that would conform with the current naming scheme within the _credits folder as well as the entire repo.
The changes made to the file _data/navigation/main.yml seems to be something that was automatically done by ide/editor. Should it be removed from the commit ?
The value of the artist key in all the new md files created does not conform same casing style. Some are camel case some are lower case. Shouldn't they all conform to the same format/casing style ?

~~Also if someone could please explain to me why this file _sass/main.scss is showing to have a merge conflict .. When it looks like @trtincher has just added a new line to it ... ?~~

@daniellex0 @dmcneary

trtincher · 2021-02-24T03:44:01Z

Reviewed this in Dev meeting on 02/23/2021 and there where duplicate files. Will remove these files and re-commit.

daniellex0 · 2021-02-25T01:50:29Z

@trtincher The page looks perfect! 🙌

Just one tiny edit:
adding margin-left: 48px
to (nested):
@media (min-width: 768px) .join-us-card-container .page-card .join-us-donation

And then it should be good to go! Thanks for all of the work on this!

akibrhast · 2021-02-28T21:14:49Z

_data/navigation/main.yml

@@ -7,10 +7,10 @@

 - name: Press
  link: /#press
-  
+


There does not seem to have been any change to this file in regards to this pull request. Any chance this could be removed from the pull request?

Do you know the git command to do that?

Not off the top of my head, no. You will have to look into that. But i believe this might be it from the contrrib.md file(Please do double check tough).

-Use the git reset HEAD command to remove a staged file.

This command will remove a file that has been staged. This file will not be committed (saved) when you run the next command, git commit. This only works if the wrong files were added, but they were not yet committed. The file will be removed from the staging area, but not actually deleted:

git reset HEAD “filename.ext”

akibrhast · 2021-02-28T21:15:47Z

join-us.html

+        alt="join us card image"
+      />
+      <div class="join-us-card-body">
+        <p class='join-us-remove-p-padding'>


Would it be possible for the content of this paragraph to be inside a liquid for loop?

Certainly possible. I see what you mean. Could be a good refactor

akibrhast · 2021-03-03T03:35:55Z

We are waiting for @martham0 to nest her classes #1154 and then this will be re-reviewed

akibrhast · 2021-03-10T03:56:27Z

@trtincher , @martham0 #1154 has now been merged

daniellex0

If everything looks good after Martha fixed her page card class that was affecting this page, then this is approved 👍

jbubar

few minor request! this looks great!
I would be curious to hear what @daniellex0 has to say about my requests.

jbubar · 2021-03-13T21:57:33Z

join-us.html

+            <a href="https://www.linkedin.com/in/bonnieawolfe/">Bonnie Wolfe</a>
+          </li>
+          <li>
+            <a href="[email protected]">Send and email</a> to our


needs to be href="mailto:[email protected]" otherwise it wont work..
Like line 149

jbubar · 2021-03-13T21:59:00Z

join-us.html

+          <li>Join our slack (if you are comfortable using slack)</li>
+          <li>
+            Connect with out Executive Director,
+            <a href="https://www.linkedin.com/in/bonnieawolfe/">Bonnie Wolfe</a>


could you add target="_blank" attribute to all of the a tags so that they all open in a new tab?

@jbubar Yes, good call 👍

Do you think I should add it to these @jbubar @daniellex0 ? Seems a bit excessive to me in this instance.

jbubar · 2021-03-13T22:01:37Z

join-us.html

+        </p>
+        <p class='join-us-remove-p-padding'>How to get involved:</p>
+        <ol>
+          <li>Join our slack (if you are comfortable using slack)</li>


Im not a designer.. but is it possible to provide a link to our slack here?

@jbubar You are totally right, thank you for catching this- here is the slack self-invite link @trtincher :

https://hackforla-slack.herokuapp.com/

(Make the word "slack" the link in "Join our slack")

Travis Tincher added 13 commits January 22, 2021 11:56

Set main layout

56eb6c5

Style Advice Card Mbl, Stle Volunteer Card Mbl

02541e4

Stle Advice Car Mbl, Stle Volunteer Card Mbl

33cc4aa

Style Partner Card Mbl

77f1f71

Style Partner with Us Mbl

b8fffda

Merge branch 'gh-pages' of https://github.com/hackforla/website into …

5631d51

…Join-Us-Page

Fix button and card classes, Desktop style for Banner

8b4c092

Style Desktop cards

6220ef1

Add links

d73b8f2

Change nav bar link

26d5974

undo mian.yml edit

9e1e2ef

fix main.yml rout

5aa413b

Merge branch 'gh-pages' into Join-Us-Page

19c6b07

update to match upstream

trtincher requested review from daniellex0 and dmcneary February 4, 2021 17:09

dmcneary suggested changes Feb 5, 2021

View reviewed changes

daniellex0 requested changes Feb 7, 2021

View reviewed changes

Travis Tincher added 6 commits February 7, 2021 12:06

Style fixes round 1

e2e4111

Margin fix

707a606

Update donation graphics

ae004a6

fixed overlaping margins

3f0e148

update banner style in tablet

fb34cd4

clarify scss comments

6ed9f68

catch branch up to main

b50591c

trtincher requested a review from daniellex0 February 24, 2021 03:23

Travis Tincher added 2 commits February 23, 2021 22:33

remove duplicate files

216c0bb

made quotes in main.scss single

49bc1b8

akibrhast reviewed Feb 28, 2021

View reviewed changes

akibrhast marked this pull request as draft March 3, 2021 03:36

akibrhast marked this pull request as ready for review March 10, 2021 03:55

daniellex0 approved these changes Mar 13, 2021

View reviewed changes

jbubar requested changes Mar 13, 2021

View reviewed changes

trtincher added 3 commits March 16, 2021 19:55

add mailto: to email link line 149

ab56bcd

add slack link

acb2f87

add target blank to a tags

1a9921d

Lol-Whut merged commit a362fda into hackforla:gh-pages Mar 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Join us page #1002

Join us page #1002

trtincher commented Feb 4, 2021 •

edited

Loading

dmcneary left a comment

daniellex0 left a comment •

edited

Loading

akibrhast commented Feb 22, 2021 •

edited

Loading

trtincher commented Feb 24, 2021 •

edited

Loading

daniellex0 commented Feb 25, 2021

akibrhast Feb 28, 2021

trtincher Mar 2, 2021

akibrhast Mar 2, 2021

akibrhast Feb 28, 2021

trtincher Mar 2, 2021

akibrhast commented Mar 3, 2021

akibrhast commented Mar 10, 2021

daniellex0 left a comment

jbubar left a comment

jbubar Mar 13, 2021

jbubar Mar 13, 2021

daniellex0 Mar 15, 2021

trtincher Mar 17, 2021

jbubar Mar 13, 2021

daniellex0 Mar 15, 2021 •

edited

Loading

jbubar Mar 15, 2021

Join us page #1002

Join us page #1002

Conversation

trtincher commented Feb 4, 2021 • edited Loading

Desktop

Mobile

dmcneary left a comment

Choose a reason for hiding this comment

daniellex0 left a comment • edited Loading

Choose a reason for hiding this comment

akibrhast commented Feb 22, 2021 • edited Loading

trtincher commented Feb 24, 2021 • edited Loading

daniellex0 commented Feb 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akibrhast commented Mar 3, 2021

akibrhast commented Mar 10, 2021

daniellex0 left a comment

Choose a reason for hiding this comment

jbubar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniellex0 Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trtincher commented Feb 4, 2021 •

edited

Loading

daniellex0 left a comment •

edited

Loading

akibrhast commented Feb 22, 2021 •

edited

Loading

trtincher commented Feb 24, 2021 •

edited

Loading

daniellex0 Mar 15, 2021 •

edited

Loading