Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove api-actionnetwork.js script from default template #7092

Closed
4 tasks done
Tracked by #6677
roslynwythe opened this issue Jul 7, 2024 · 4 comments · Fixed by #7360
Closed
4 tasks done
Tracked by #6677

Remove api-actionnetwork.js script from default template #7092

roslynwythe opened this issue Jul 7, 2024 · 4 comments · Fixed by #7360
Assignees
@maadeshsivakumar
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Milestone
x. Technical debt

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jul 7, 2024 •
edited by t-will-gillis
Loading

Overview

We need to remove the script reference to api-actionnetwork.js from our default template, because the script is no longer required.

Action Items

  • Open _layouts/default.html in your IDE
  • Remove the script tag that references assets/js/api-actionnetwork.js
  • Using Docker, view a sample page (for example /events) and confirm that it is unchanged from the production webpage.

Merge Team:

Resources/Instructions

Liquid templating language
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 7, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: HfLA Website: Project Board Jul 7, 2024
@roslynwythe roslynwythe added Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Jul 7, 2024
@github-actions github-actions bot removed the Complexity: Small Take this type of issues after the successful merge of your second good first issue label Jul 7, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@roslynwythe roslynwythe added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML ready for product and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 7, 2024
@roslynwythe

This comment was marked as resolved.

Sign in to view
@roslynwythe roslynwythe mentioned this issue Jul 7, 2024
Closed
11 tasks
@ExperimentsInHonesty

This comment was marked as resolved.

Sign in to view
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Jul 13, 2024
@t-will-gillis t-will-gillis mentioned this issue Aug 18, 2024
Closed
4 tasks
@t-will-gillis t-will-gillis added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Aug 18, 2024
@ExperimentsInHonesty ExperimentsInHonesty added Complexity: Missing ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Aug 19, 2024
@roslynwythe roslynwythe added Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on Ready for Prioritization Complexity: Missing labels Aug 21, 2024
@maadeshsivakumar maadeshsivakumar self-assigned this Aug 27, 2024
@maadeshsivakumar maadeshsivakumar moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Aug 27, 2024
@HackforLABot
Copy link
Contributor

Hi @maadeshsivakumar, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

maadeshsivakumar added a commit to maadeshsivakumar/website that referenced this issue Aug 27, 2024
@maadeshsivakumar
Removed api-actionnetwork.js script hackforla#7092
043af65
@maadeshsivakumar maadeshsivakumar mentioned this issue Aug 27, 2024
Merged
t-will-gillis pushed a commit that referenced this issue Aug 31, 2024
@maadeshsivakumar
Removed api-actionnetwork.js script #7092 (#7360)
3b8e9e3
@github-project-automation github-project-automation bot moved this from In progress (actively working) to QA in P: HfLA Website: Project Board Aug 31, 2024
@daras-cu daras-cu mentioned this issue Sep 23, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maadeshsivakumar maadeshsivakumar

Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Status: QA
Milestone
x. Technical debt
Development

Successfully merging a pull request may close this issue.

Removed api-actionnetwork.js script in default template maadeshsivakumar/website
5 participants
@roslynwythe @ExperimentsInHonesty @t-will-gillis @maadeshsivakumar @HackforLABot