Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wiki page "How to manage spell check warnings" #6519

Closed
7 tasks done
Tracked by #6446
roslynwythe opened this issue Mar 26, 2024 · 29 comments
Closed
7 tasks done
Tracked by #6446

Create wiki page "How to manage spell check warnings" #6519

roslynwythe opened this issue Mar 26, 2024 · 29 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Mar 26, 2024

Overview

We require a wiki page to guide developers how to manage and resolve spell check warnings

Action Items

  • We are currently in the process of moving the old wiki to the new website-wiki repo, so we will not be making any changes or additions to the old wiki at this time. Thus, we will be adding wiki content through a different process now. Read How to Contribute to the Wiki
  • Create a wiki page "How to manage spell check warnings" that covers the following topics:
    • Introduction to spell checking
    • Managing misspelled words
    • Managing false positives
    • Excluding a section of code from spell checking
    • Excluding a file or folder from spell checking

Resources/Instructions

Resources/Instructions

Introduction to JSON
Code Spell Checker


@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Mar 26, 2024

This comment has been minimized.

@roslynwythe roslynwythe added Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Mar 26, 2024
@roslynwythe roslynwythe self-assigned this Mar 26, 2024

This comment has been minimized.

@roslynwythe
Copy link
Member Author

roslynwythe commented Mar 26, 2024

Draft wiki page "How to manage spell check warnings"

Hack for LA developers are instructed to use Spell Checker for VS Code or the cspell npm package as described in CONTRIBUTING.md Section 1.7. Both versions are intended for working with code files and both utilitze the configuration file cspell.json in the root of the website folder. In the future, cspell-based spell checking will also be incorporated into the GitHub checks which take place in pull requests.

Developers should note spell check warnings (i.e, "unknown word") and resolve them as described below, prior to creating a pull request. File changes made to resolve spell check warnings will be considered within the scope of the linked issue, but should be noted in the Pull Request.

Resolving spell check warnings

- [ ] If there was a genuine misspelling, make the spelling correction(s) 
- [ ] If the "unknown word" should be considerd a "word" (ie "markdownify"), edit the file `cspell.json` and add the term to the "words" array
- [ ] If the "unknown word" should be ignored by the spell checker (such as the name of an individual) edit the file 'cspell.json` and add the term to the "ignoreWords" array
- [ ] It is possible to disable / enable the spell checker for a section of code by adding comments.   Details depend on the file type and can be found in [Code Spell Checker documentation](https://streetsidesoftware.com/vscode-spell-checker/)
- [ ] If the entire file should be excluded from spell checking, because it contains no public-facing text, edit the file `cspell.json` and add the file path to the `ignorePaths` array

@roslynwythe roslynwythe self-assigned this Mar 26, 2024

This comment has been minimized.

@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label Mar 26, 2024
@roslynwythe roslynwythe self-assigned this Mar 26, 2024

This comment has been minimized.

@roslynwythe
Copy link
Member Author

roslynwythe commented Mar 26, 2024

@ExperimentsInHonesty In the wiki page I would have liked to reference the issue template for resolving spell check errors, but that link doesn't exist yet so I omitted it.

@github-actions github-actions bot added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed To Update ! No update has been provided labels Apr 26, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@LRenDO

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@HackforLABot

This comment has been minimized.

@HackforLABot

This comment has been minimized.

@HackforLABot

This comment was marked as outdated.

@HackforLABot

This comment was marked as outdated.

@github-project-automation github-project-automation bot moved this from In progress (actively working) to QA in P: HfLA Website: Project Board Sep 16, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks Added to dev/pm agenda ready for dev lead Issues that tech leads or merge team members need to follow up on labels Sep 17, 2024
@kgold2018 kgold2018 moved this from QA to Done in P: HfLA Website: Project Board Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

4 participants