Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of Daniel Ridge bot its repo 'check-ghpages-versions' #5897

Closed
5 tasks done
roslynwythe opened this issue Nov 13, 2023 · 11 comments
Closed
5 tasks done
Assignees
Labels
Complexity: Medium Feature: Infrastructure For changes on site technical architecture ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Nov 13, 2023

Overview

We need to understand the purpose and status of the Daniel Ridge bot and its repo 'check-ghpages-versions', to determine if the Website team should take responsibility for maintaining it.

Details

Daniel Ridge Bot repo 'check-ghpages-versions' is intended to automatically check the dependencies for the Docker image created from ghpages-docker, and when necessary, to update the ghphages-docker Dockerfile, build a new image and push it to Docker Hub.

Action Items

Resources/Instructions

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Nov 13, 2023

This comment was marked as resolved.

@roslynwythe roslynwythe added Complexity: Medium role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours Feature: Infrastructure For changes on site technical architecture ready for product and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Nov 13, 2023
@roychan1 roychan1 self-assigned this Nov 25, 2023
Copy link

Hi @roychan1, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roychan1
Copy link
Member

i. Availability: 9am-5pm
ii. ETA: 11/27 at the earliest

@roslynwythe
Copy link
Member Author

Hi @roychan1 I wanted to bring these comments to your attention: #5644 (comment) and #5644 (comment)

Copy link

github-actions bot commented Dec 8, 2023

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, December 4, 2023 at 11:06 PM PST.

@roychan1
Copy link
Member

roychan1 commented Dec 9, 2023

  1. Progress: I have done research on the DanielRidge Bot, ghpages-docker, check-ghpages-versions repositories.
  2. Blockers: I have difficulty figuring out a solution, I will communicate with someone on slack channels.
  3. Availability: I will work on it this weekend (12/9 - 12/10).
  4. ETA: 4 days.

@roychan1 roychan1 added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Dec 9, 2023
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Dec 15, 2023
@roslynwythe
Copy link
Member Author

Hi @roychan1, please advise, was the "Keep-Alive Workflow" a viable solution?

@roychan1
Copy link
Member

Hi @roychan1, please advise, was the "Keep-Alive Workflow" a viable solution?

Hi @roslynwythe , I verified that the check-ghpages-versions workflow did pause due to inactivity for 60 days, as shown in this screenshot:
Screenshot 2023-12-15 233956

The "Keep-Alive Workflow" should be a viable solution, as it is intended for cron based triggers, like Check Github Pages Gem Version and Open New Issue on Change from the check-ghpages-versions repo.

As specified in the How To Use section of the Keep-Alive Workflow documentation, its workflow name will just needed to be specified as the last step in Check Github Pages Gem Version and Open New Issue on Change workflow from check-ghpages-versions, and read/ write permissions has to be enabled on the check-ghpages-versions repo.

I believe the workflow is still needed because I verified that the version of the GitHub page ruby gem has fallen out of date. github-pages-gem.txt shows version 227 (newest version detected, not necessarily updated), while Official GitHub Pages Versions shows version 228.

The check-ghpages-versions repo's GitHub actions should have opened an issue in hackforla/ops notifying about version update, and when version in the dockerfile is updated, ghpages-docker repo's GitHub actions would rebuild the image and push it to DockerHub. The Dockerfile was stale most likely because no issues were opened to notify about version updates due to the stopping of the bot, and consequently the Docker image was not rebuilt and pushed to DockerHub. Fixing of the bot should prevent a stale dockerfile moving forward.

I have not tested the "Keep-Alive Workflow" myself so I cannot say that it functions as intended. Should I test it as part of this issue? Is there any more information I should provide or subjects I should look into for this issue? Please let me know if clarifications are needed. Thank you.

Copy link

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, December 25, 2023 at 11:06 PM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Dec 29, 2023
@roychan1 roychan1 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jan 1, 2024
@roychan1
Copy link
Member

roychan1 commented Jan 1, 2024

  1. Progress: I have included findings in this comment: Investigate use of Daniel Ridge bot its repo 'check-ghpages-versions'  #5897 (comment) and added "ready for dev lead" label. I am awaiting on a response regarding the issue.
  2. Blockers: N/A
  3. Availability: day time during the week of 12/31 - 1/6
  4. ETA: less than a week, depending on the status of review

@roychan1 roychan1 added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Jan 1, 2024
@roslynwythe
Copy link
Member Author

@roychan1 thank you for the analysis and recommendation. This issue will be closed as completed and a new issue created for implementing the "Keep-Alive Workflow". If you are interested in writing the new issue, please message me on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Infrastructure For changes on site technical architecture ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

No branches or pull requests

3 participants