Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VS Code Spell Checker on _layouts/guides.html #5604

Closed
8 of 9 tasks
Tracked by #5248
roslynwythe opened this issue Sep 26, 2023 · 6 comments
Closed
8 of 9 tasks
Tracked by #5248

Run VS Code Spell Checker on _layouts/guides.html #5604

roslynwythe opened this issue Sep 26, 2023 · 6 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 26, 2023

Overview

We need to audit HfLA codebase files for spelling errors using the Code Spell Checker extension in VS Code in order to ensure site quality. Results will be categorized as misspellings or false positives in the HfLA spelling audit spreadsheet1 and will be resolved in later issues.

Action Items

  • You must use VS Code as your local text editor and install the Code Spell Checker VS Code extension2
  • Do not change any configuration settings or make any spell corrections
  • Open the file '_layouts/guides.html' and note any Code Spell Checker errors
  • Locate the file in column A ("File") of the "Page Audit" sheet. In the column labeled "Result Summary", select the appropriate option: No errors or At least one error.
  • If at least one error was reported, copy/paste each cSpell message into a separate row in the Results sheet
  • In each new row, select the appropriate value: misspelling or false positive from the "Result type" column. A false positive is a term that is not a misspelling but is not recognized by the spell checker because it is a technical term, abbreviation, acronym, URL or proper noun (name of a person, place or organization).
  • Move this issue to the Questions/In Review column and apply the label ready for dev lead

Merge Team

Resources/Instructions

Footnotes

  1. HfLA spelling audit spreadsheet - Results

  2. The recommended installation method is to install Code Spell Checker directly from the VS Code text editor, and those instructions can be found here. The extension can also be installed via the VS Code Marketplace website here.

@roslynwythe roslynwythe added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.5pt Can be done in 3 hours or less and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Sep 26, 2023
@github-actions github-actions bot added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 26, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Sep 26, 2023
@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 26, 2023
@njackman-2344 njackman-2344 self-assigned this Sep 27, 2023
@github-actions
Copy link

Hi @njackman-2344, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@njackman-2344
Copy link
Member

Availability: Friday 5pm - 10pm PST 9/29

ETA: Tuesday night 10/3

@njackman-2344
Copy link
Member

#5604
Ran VS Code Spell Checker in page and it came up with false positive on "markdownify":unknown word.

I input the false positive into the spreadsheet on a27 in results page and the word was already there in false positives
page.

@njackman-2344 njackman-2344 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 1, 2023
@LRenDO
Copy link
Member

LRenDO commented Oct 4, 2023

Hi @njackman-2344! Great job with this issue! It looks like there are errors on my end too! You also did a great job with moving the issue to the right column and adding the correct label.

I do have one request.

  • On the Results sheet of the spreadsheet please add both instances (even though they are the same word) of the error message found in the Problems list in VS Code.

Once it's completed, you can ping me here in a comment to let me know and add the ready for dev lead tag back to the issue. Thanks for working on this issue!

@LRenDO LRenDO removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 4, 2023
@njackman-2344
Copy link
Member

njackman-2344 commented Oct 4, 2023

@LRenDO I have added both instances with [ln,Col]. THank you!

@njackman-2344 njackman-2344 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 4, 2023
@LRenDO
Copy link
Member

LRenDO commented Oct 4, 2023

Hi @njackman-2344! Looks great! Thanks for making the update!

@LRenDO LRenDO closed this as completed Oct 4, 2023
@LRenDO LRenDO removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 4, 2023
@ExperimentsInHonesty ExperimentsInHonesty added feature: spelling and removed Feature: Administrative Administrative chores etc. labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

4 participants