Add redirect for broken links on "Project Team Meetings" page

[t-will-gillis]

Overview

On our project-meetings and events pages the hrefs to "People Depot" and "Tables" link to an undefined page "https://www.hackforla.org/projects/people-depot". We want the href for "People Depot" and "Tables" to link to each project's GitHub account until they have pages in the _projects folder.

Action Items

The API_ENDPOINT for data on the project meetings page comes from VRMS. The query to VRMS returns an "event" object, and event.hflaWebsiteUrl == "" for both "People Depot" and "Tables" since neither has a project page on the website.

• In the file api-events.js we want to redirect the links for "People Depot" and for "Tables" by inserting the following code after if (event) { on Line 35 and before let eventHtml; on Line 36:

// If a project doesn't have an hflaWebsiteUrl, redirect to the project's GitHub page
if (event.hflaWebsiteUrl == "") {
  event.hflaWebsiteUrl = event.githubUrl
}

• Near the end of the same file in function display_object(item), we need to query the githubUrl from VRMS by adding the following entry in const rv_object after the hflaWebsiteUrl:

githubUrl: item.project.githubUrl,

• Confirm that this link and the others work correctly on the project-meetings and events pages.

Resources/Instructions

Screenshot showing current link when "People Depot" is selected on "Project Meetings" page

Screenshot showing current link when "People Depot" is selected on "Events" page

[github-actions]

Hi @yffu, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[yffu]

i. Availability: After 5 PT Daily
ii. ETA: 07/29 (Sat)

[yffu]

Have a blocker/question, wondering if someone could help:

2. Blockers:
   on project-meetings page there's an underscore after the project name
   

on events page there is "All Teams"

working on the 'add-redirect-for-broken-links-4906' branch on my forked repo.

I was thinking to change the project-meetings underscore to match the events page "All Team" but wanted to check. Thanks in advance for your help!

[t-will-gillis]

Hey @yffu - Good question- thanks for asking!

The short answer is that this needs to be changed in VRMS, which we don't have access to. I will ask Matt P. or Bonnie if they can edit this.

Here's the long answer: project managers for each project enter details about their meetings into the VRMS app. The "Project Meetings" (and "Events") pages are querying data from VRMS- see api-events.js. Here is the object data that the page receives from VRMS:

See lower left: People Depot and Community of Practice: Engineering

So the underscore on the "Project Meetings" page is coming from the entry for "dsc" in People Depot's VMRS.

[t-will-gillis]

@MattPereira could you edit People Depot's VMRS entry for "dsc" in their Thursday 4-5 meeting? Currently it there is an underscore, so could this be changed to a blank "" or maybe "Weekly meeting" ? Last I heard, no one at People Depot has access to VMRS...

[MattPereira]

@t-will-gillis got u fam its a blank string now ""

also i'll reach out to fang to ensure he has access

[yffu]

Thanks for the answer @t-will-gillis. It makes sense that it's from vrms so that it's flexible. Much appreciate the explanations and the examples in the screenshots.