Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Change to Wins Form, Apps Script and JS to implement new URL validation strategy #4671

Open
1 of 3 tasks
Tracked by #7664
roslynwythe opened this issue May 15, 2023 · 1 comment
Open
1 of 3 tasks
Tracked by #7664
Labels
Complexity: Large Complexity: Medium Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created epic P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours size: 2pt Can be done in 7-12 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented May 15, 2023

Dependencies

The following issues are part of this epic

Overview

As developers we need to first implement a strategy for collecting the GitHub and LinkedIn URLs in a manner that is user-friendly and secondly to store the essential part of those URLs (the profile descriptors) in an efficient and reusable manner, and finally to ensure a consistent appearance of the URLs on the Wins webpage.

Resources/Instructions

Bonnie's explanation of what we are trying to accomplish

How is the page code interpreting and or rationalizing the urls being provided. (e.g., Is it taking everything with http and transforming it into https? etc.)

What I am getting at is, that we should clean the url string before it gets to the data store, if at all possible. So if we want to store just the username for inkedin and github that is ok. if we want to store the whole string, then the string should be formatted with https: without the www even though linkedin allows either with or without the www.

https://www.linkedin.com/in/bonnieawolfe
https://linkedin.com/in/bonnieawolfe
But at the same time, we don't want to make it hard for the person entering the info, so we will accept any version of the input but must store it uniformly.

http://linkedin.com/in/bonnieawolfe
https://linkedin.com/in/bonnieawolfe
http://www.linkedin.com/in/bonnieawolfe
https://linkedin.com/in/bonnieawolfe
And then we would need a script after the fact that cleans the data turning it into either (my preference being just the username)

https://linkedin.com/in/bonnieawolfe
bonnieawolfe

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing and removed epic labels May 15, 2023
@roslynwythe roslynwythe added P-Feature: Wins Page https://www.hackforla.org/wins/ epic role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium Complexity: Large and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels May 15, 2023
@roslynwythe roslynwythe self-assigned this May 15, 2023
@github-actions
Copy link

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label May 15, 2023
@wanyuguan wanyuguan added the Dependency An issue is blocking the completion or starting of another issue label May 28, 2023
@kimberlytanyh kimberlytanyh changed the title Change to Wins Form, Apps Script and JS to implement new URL validation strategy Epic: Change to Wins Form, Apps Script and JS to implement new URL validation strategy Sep 10, 2023
@roslynwythe roslynwythe added size: 1pt Can be done in 4-6 hours size: 2pt Can be done in 7-12 hours and removed size: missing labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Complexity: Medium Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created epic P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours size: 2pt Can be done in 7-12 hours
Projects
Development

No branches or pull requests

3 participants