Change input validation settings on WINS form to prevent invalid URL entries

[roslynwythe]

Prerequisite

1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

As developers we need to update input validation settings on the LinkedIn URL and GitHub URL fields of the "Share your WINS" form, so that invalid URLs are not accepted.

Action Items

• On your personal or your development Google Drive, create a new test Google Form with two questions: GitHub URL and LinkedIn URL. In the Response settings of the Form, link to a new spreadsheet for storing responses.
• For both the LinkedIn and GitHub URL fields, open the question settings, click the arrow next to Text, and select Regular Expression. Provide a case-insensitive Regular Expression for matching each specific expected URL.
  • For both URLs, the protocol portion of the URL should match http://, https://, or it could be blank.
  • For the GitHub URL, the remainder of the URL should start with www.github.com/ or github.com/
  • For the LinkedIn URL, the remainder of the URL should start with www.linkedIn.com/in/ or linkedIn.com/in/
  • Both URLs should end with the profile descriptor, optionally followed by /
• Test by submitting the form with various inputs. Verify that only the URL patterns described above can be submitted and that the responses in the test Sheet are correct.
• Configure draft error messages to guide users who have entered invalid responses
  • Get sign off from product on the error messages.
• Demonstrate the regular expressions for dev lead.

Merge Team/Dev Leads

• Before closing this issue,
  • Update the production Google Form with the regular expressions and error messages for the GitHub and LinkedIn URLs.
  • Test form validation with various inputs. Submit a test form, then verify the submitted data for the Github and Linked URLS in the response Sheet matches the current formats. Find the automatically generated GitHub issue with title "Review Needed - New Wins Form Submission", add the "Ignore:Test" label, make a comment and close as Not Planned.

Resources/Instructions

• Share Your WINS form
• This issue was created as a result of ER from TLDL: Feasibility of validating fields on Wins Form #4185
• Google helpfile on form regex and error messages https://support.google.com/docs/answer/3378864?hl=en

[github-actions]

Hi @brianf4, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[brianf4]

Availability: Sunday - Friday 10 am - 8 pm
ETA: Friday - EOD

[brianf4]

Here is the Google Form with the input validation settings: https://forms.gle/vvcsr9ijgYBBFAsQ7

As well as the Google Sheet for the responses that went through/allowed: https://docs.google.com/spreadsheets/d/1eMUxEMOC-Py0twk-CkEPNDQLoiqgLzpOU42f3LETL9Q/edit?usp=sharing

Regex expression for both input:

• ^([Hh][Tt][Tt][Pp][Ss]?://)?([Ww][Ww][Ww].)?[Gg][Ii][Tt][Hh][Uu][Bb].[Cc][Oo][Mm]/[A-Za-z0-9-]+/?$
• ^([Hh][Tt][Tt][Pp][Ss]?://)?([Ww][Ww][Ww].)?[Ll][Ii][Nn][Kk][Ee][Dd][Ii][Nn].[Cc][Oo][Mm]/[Ii][Nn]/[A-Za-z0-9-]+/?$

Valid GitHub URL examples:

• https://github.com/fakeuser123/
• https://www.github.com/johndoe-123/
• http://github.com/username_with-dashes/
• https://github.com/camelCaseUser/
• https://github.com/brianf4/
• https://github.com/Asalz20/

Valid LinkedIn URL examples:

• https://www.linkedin.com/in/fake-user-123/
• https://linkedin.com/in/janedoe-456/
• http://linkedin.com/in/some_user/
• https://www.linkedin.com/in/camelCaseUser/
• https://www.linkedin.com/in/brian-fuentes-18ab62182/
• https://www.linkedin.com/in/alex-salazar-dev/
• https://linkedin.com/in/alex-salazar-dev/

Invalid GitHub URL examples:

• https://github.com/.git
• https://www.github.com/.test
• http://github.com/
• https://www.example.com/
• ftp://github.com/user123/

Invalid LinkedIn URL examples:

• https://linkedin.com/in/.test
• https://www.linkedin.com/in/.git
• http://linkedin.com/in/
• https://www.example.com/
• ftp://linkedin.com/in/user123/

Error Message: "Invalid GitHub/LinkedIn URL"

[roslynwythe]

Thanks @brianf4 - This looks good to me but I'd like to give the merge team a few days to test the form as well.

[t-will-gillis]

@brianf4 @roslynwythe I tried different variations and tried to think of an exception to trip up the regex. So far everything looks good to me.

[roslynwythe]

Thank you @brianf4 for great work on this issue. The regular expressions you created will help to ensure that our Wins form recieves valid URLs.