Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Program Areas filter for Diversity, Equity & Inclusion #4120

Closed
1 of 2 tasks
Tracked by #3328
JessicaLucindaCheng opened this issue Mar 6, 2023 · 12 comments · Fixed by #4270
Closed
1 of 2 tasks
Tracked by #3328

Fix Program Areas filter for Diversity, Equity & Inclusion #4120

JessicaLucindaCheng opened this issue Mar 6, 2023 · 12 comments · Fixed by #4270
Assignees
Labels
Bug Something isn't working Complexity: Medium P-Feature: Program Area https://www.hackforla.org/program-areas P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 6, 2023

Dependency

Overview

We need to fix the Program Areas filter on the projects page so that website visitors can filter and find the projects with the Diversity, Equity & Inclusion program area.

Demonstration of the bug

filter bug

Action Items

  • In assets/js/current-projects.js, fix the Program Areas filter on the projects page so that it works for Diversity, Equity & Inclusion.

Merge Team, Technical Lead, or Product Manager

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added Bug Something isn't working role: front end Tasks for front end developers Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ size: 1pt Can be done in 4-6 hours labels Mar 6, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Draft Issue is still in the process of being created Dependency An issue is blocking the completion or starting of another issue and removed Draft Issue is still in the process of being created labels Mar 6, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title Fix Program Areas filter for Diversity, Equity & Inclusion Fix Program Areas filter for Diversity, Equity & Inclusion Mar 6, 2023
@JessicaLucindaCheng

This comment was marked as outdated.

@jdingeman jdingeman added ready for dev lead Issues that tech leads or merge team members need to follow up on Ready for Prioritization and removed Dependency An issue is blocking the completion or starting of another issue ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 14, 2023
@jdingeman

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Mar 15, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the time sensitive Needs to be worked on by a particular timeframe label Mar 16, 2023
@ExperimentsInHonesty

This comment was marked as outdated.

@jdingeman

This comment was marked as outdated.

@jdingeman jdingeman removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 16, 2023
@t-will-gillis t-will-gillis self-assigned this Mar 19, 2023
@github-actions
Copy link

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@t-will-gillis
Copy link
Member

Availability: Tues 3/21
ETA: Tues 3/21 5 pm

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Mar 22, 2023

@t-will-gillis

@ExperimentsInHonesty @JessicaLucindaCheng
I am working on #4120 - Yes "Diversity / Equity / Inclusion" will work - I just checked.

(The previous "Diversity, Equity & Inclusion" had problems not only because of the "&" but also because of the ",". Even removing the ampersand, with the comma the dropdown was splitting into two unique program areas of "Diversity" and "Equity and Inclusion" . )

Perfect! Let's make that change (change the Program Area to be Diversity / Equity / Inclusion) on this issue. Which solves the problem, It's a better solution than editing the script.

@t-will-gillis
Copy link
Member

@ExperimentsInHonesty @JessicaLucindaCheng While I am changing the cards to Diversity / Equity / Inclusion, do we want to change the 'Join Us' page (it needs a comma at least...):
join us
do we want to change the 'About' page:
about
and finally the title on the Program Areas page:
after_program_areas

@ExperimentsInHonesty
Copy link
Member

@t-will-gillis Go ahead and make an ER for updating it to say Diversity, Equity & Inclusion every place that does not use a dropdown or other feature that would make that non feasible.

@ExperimentsInHonesty
Copy link
Member

@t-will-gillis are you putting in a pr on this issue to change the text in the project.md files from

program-area: 
  - Diversity, Equity & Inclusion

to

program-area: 
  - Diversity / Equity / Inclusion

for the following projects?

  • New Schools Today
  • Write for All

Or are you making new issues for those two files and the changes?

@ExperimentsInHonesty ExperimentsInHonesty added the P-Feature: Program Area https://www.hackforla.org/program-areas label Mar 27, 2023
@t-will-gillis
Copy link
Member

@ExperimentsInHonesty PR #4270 is in review currently and will change both new-schools-today.md and writeforall.md to:

program-area: 
  - Diveristy / Equity / Inclusion

Then there are three separate issues for changing program area to be Diversity, Equity & Inclusion everywhere else if it will not cause a bug:

Is this what you are asking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Medium P-Feature: Program Area https://www.hackforla.org/program-areas P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

4 participants