Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest version of Google Apps Scripts to GitHub #3641

Closed
13 of 16 tasks
aricforrest opened this issue Oct 19, 2022 · 27 comments · Fixed by #4365
Closed
13 of 16 tasks

Add latest version of Google Apps Scripts to GitHub #3641

aricforrest opened this issue Oct 19, 2022 · 27 comments · Fixed by #4365
Assignees
Labels
Complexity: Medium Feature: Infrastructure For changes on site technical architecture role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less

Comments

@aricforrest
Copy link
Member

aricforrest commented Oct 19, 2022

Overview

The Google Apps Scripts used by the website project should be added to the website git repository. This will allow version control and tracking of changes made to the App Scripts over time.

Action Items

  • Obtain view access to wins-form (response) Sheet and gh-requests (Doc) in the admin Google drive share from a technical lead
  • Install node.js and npm (if they are not already installed) on the local workstation
  • Update your local gh-pages branch with upstream changes, then checkout a new issue branch
  • edit .gitignore to add a line containing the filename .clasp.json, then run git add .gitignore
  • Create a folder called "google-apps-scripts" in the root of the website repository.
  • From within the "google-apps-scripts" folder, create a subfolder for each Apps Script project listed below. In each subfolder, execute the commands npm install clasp and npm install @types/google-apps-script
    • wins-form-responses
    • gh-requests
  • From either of the above subfolders, execute the command clasp login, then authenticate to Google Drive and grant permissions to the clasp app
  • In each subfolder, clone the script using the command clasp clone <ID> where the script ID can be found on the corresponding Projects Settings page in the Google Drive IDE, then use git add to add the following files to the new issue branch: Code.js, appsscript.json, package.json, package-lock.json
    • wins-form-responses
    • gh-requests
  • run git commit, then push changes to your fork of gh-pages, then create PR in the usual manner.

Merge Team - Upon Completion

Example folder structure:
├── google-apps-scripts
│   └── wins-form-responses
│         └── Code.js, appscript.json, package-lock.json, package.json

Resources

@aricforrest aricforrest added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Infrastructure For changes on site technical architecture size: 0.5pt Can be done in 3 hours or less labels Oct 19, 2022
@aricforrest aricforrest changed the title Standard Feasibility Issue Template Add latest version of Google Apps Scripts to Git Oct 19, 2022
@aricforrest aricforrest changed the title Add latest version of Google Apps Scripts to Git Add latest version of Google Apps Scripts to GitHub Oct 19, 2022
@aricforrest aricforrest added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 19, 2022
@ExperimentsInHonesty

This comment was marked as resolved.

@blulady

This comment was marked as resolved.

@aricforrest

This comment was marked as resolved.

@blulady

This comment was marked as resolved.

@blulady blulady added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 26, 2022
@roslynwythe roslynwythe self-assigned this Nov 2, 2022
@github-actions

This comment was marked as outdated.

@roslynwythe

This comment was marked as outdated.

@roslynwythe

This comment was marked as outdated.

@roslynwythe

This comment was marked as outdated.

@roslynwythe roslynwythe removed their assignment Nov 3, 2022
@roslynwythe

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@arpitapandya

This comment was marked as outdated.

@arpitapandya

This comment was marked as outdated.

@arpitapandya

This comment was marked as outdated.

@roslynwythe

This comment was marked as resolved.

@roslynwythe roslynwythe added ready for product and removed Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 19, 2023
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Mar 21, 2023
@ExperimentsInHonesty

This comment was marked as outdated.

@jdingeman

This comment was marked as outdated.

@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 24, 2023
@Sebster3 Sebster3 self-assigned this Mar 24, 2023
@Sebster3
Copy link
Member

ETA: Monday 3/27 EOD
Availability 1-4PM Fri, 6-9PM Mon

@Sebster3
Copy link
Member

I have a blocker on the following action items:

  1. From either of the above subfolders, execute the command clasp login, then authenticate to Google Drive and grant permissions to the clasp app.

    I'm able to successfuly log into my personal google account (which has access to the HFLA Drive), however I wasn't asked specifically to provide access to the HFLA Drive—which the action item seems to imply should happen. Is it sufficient for clasp to be authenticated using my google account?

  2. In each subfolder, clone the script using the command clasp clone <ID> where the script ID can be found on the corresponding Projects Settings page in the Google Drive IDE, then use git add to add the following files to the new issue branch: Code.js, appsscript.json, package.json, package-lock.json

    I'm not sure where to find the "Project Settings" page or anything resembling a script ID for the two files mentioned in the issue: wins-form-responses, gh-requests.

There's currently no active branch for this issue on my forked repo as the final action item consists of pushing the changes made in the previous steps.

Thanks in advance for the help!

@roslynwythe
Copy link
Member

Hi @Sebster3 -
Thank you for taking up this issue. I'm not sure why you weren't asked to authorize clasp to access your Google Drive. Let's see what happens when you run the clone command. To get the project id, open the production Sheet (or Doc), then click Extensions..Apps Script, then click the Project Settings (gear) icon in the left column. The ID can be copied from the Project Settings page.

You should be working in a new issue branch created in Action Item #3. That branch will be pushed to a branch on your forked repo as the final action item.

@Sebster3
Copy link
Member

Thanks for helping @roslynwythe! It looks like I'll need edit access to Wins-form (Responses) in Drive before I can access the Extensions menu. Also, the gh-requests file doesn't appear to have an Extensions menu, which could be a follow up problem after we sort out getting proper permissions on the first file.

Screen Shot 2023-03-29 at 11 40 51 AM

@roslynwythe
Copy link
Member

Thanks for helping @roslynwythe! It looks like I'll need edit access to Wins-form (Responses) in Drive before I can access the Extensions menu. Also, the gh-requests file doesn't appear to have an Extensions menu, which could be a follow up problem after we sort out getting proper permissions on the first file.

Screen Shot 2023-03-29 at 11 40 51 AM

Permissions have been granted. You should now see an Extensions menu on gh-requests. Let me know if you don't.

@Sebster3
Copy link
Member

Sebster3 commented Apr 1, 2023

Hm, the Extensions menu on wins form remains greyed out and there is no Extensions menu available on gh-requests.

Screenshot 2023-04-01 124722

I've sent edit requests directly from the files. hopefully that helps.

@Sebster3
Copy link
Member

Sebster3 commented Apr 2, 2023

Thanks @roslynwythe! The recent set of permissions you provided got everything back on track and a PR is now open :)

#4365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Infrastructure For changes on site technical architecture role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

7 participants