Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Apps Script: Migrate Wins Data - Delete AF file #2148

Open
3 tasks
Tracked by #4134
Aveline-art opened this issue Aug 20, 2021 · 8 comments
Open
3 tasks
Tracked by #4134

Google Apps Script: Migrate Wins Data - Delete AF file #2148

Aveline-art opened this issue Aug 20, 2021 · 8 comments
Labels
Complexity: Medium Dependency An issue is blocking the completion or starting of another issue P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@Aveline-art
Copy link
Member

Aveline-art commented Aug 20, 2021

Dependency

Overview

As a developer, to turn the wins card into a reusable component, we must first be able to generate a wins-data.json file of a more specific format. This issue is part of a series that aims to migrate us to the more specific format.

Action Items

  • Read the resources/instructions below to understand your task.
  • Delete the AF version of our file from our codebase.
  • Check and make sure that all pages in the website still appears as before this change.

Resources/Instructions

wins-page

Currently we have two json files for wins: _wins-data.json and wins-data.json. The former will henceforth be called KVF (for key-value file) and AF (for array file). AF is generated daily from a script on google while KVF appears to be an older, dysfunc version. The format in the KVF version, however, is much friendlier to formatting in liquid syntax. Therefore, we need to incrementally port our codebase to use the KVF version of the data and remove the AF version we currently use. This will be done in multiple steps:

  1. Have the apps script generate both AF and KVF version.
  2. Migrate all uses of AF to KVF.
  3. Have the apps script stop generating the AF version.
  4. Delete the AF version from our repo since it is now unused.

For this issue, we are doing step 4.

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 20, 2021
@Aveline-art Aveline-art added P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers Size: Good second issue Dependency An issue is blocking the completion or starting of another issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 20, 2021
@macho-catt macho-catt changed the title Migrate Wins Data: Delete AF file Google Apps Script: Migrate Wins Data - Delete AF file Nov 2, 2021
@macho-catt macho-catt added Feature: Google Apps Scripts Automation related to Google Apps Scripts and removed Feature: Google Apps Scripts Automation related to Google Apps Scripts labels Nov 21, 2021
@ExperimentsInHonesty ExperimentsInHonesty added this to the y. Technical debt milestone Mar 6, 2022
@SAUMILDHANKAR SAUMILDHANKAR added the size: 0.5pt Can be done in 3 hours or less label Jun 19, 2022
@steven-positive-tran steven-positive-tran self-assigned this Jan 28, 2023
@github-actions
Copy link

Hi @steven-positive-tran, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@steven-positive-tran

This comment was marked as resolved.

@jdingeman

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@AHP15

This comment was marked as outdated.

@roslynwythe

This comment was marked as outdated.

@AHP15

This comment was marked as resolved.

@roslynwythe

This comment was marked as resolved.

@roslynwythe roslynwythe added Complexity: Medium size: 1pt Can be done in 4-6 hours ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Dependency An issue is blocking the completion or starting of another issue size: 0.5pt Can be done in 3 hours or less good first issue Good for newcomers labels Feb 22, 2024
@ExperimentsInHonesty ExperimentsInHonesty added Dependency An issue is blocking the completion or starting of another issue and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Dependency An issue is blocking the completion or starting of another issue P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging a pull request may close this issue.

9 participants