Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit content field and remove type field from donate.yml credits file #2823

Closed
5 tasks done
Tracked by #2775
usaboo opened this issue Feb 21, 2022 · 5 comments · Fixed by #3625
Closed
5 tasks done
Tracked by #2775

Edit content field and remove type field from donate.yml credits file #2823

usaboo opened this issue Feb 21, 2022 · 5 comments · Fixed by #3625
Assignees
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review

Comments

@usaboo
Copy link
Member

usaboo commented Feb 21, 2022

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/donate.yml, do the following:

Resources/Instructions

File and Code links you will need to work on this issue

@usaboo usaboo added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Credit https://www.hackforla.org/credits/ size: 0.5pt Can be done in 3 hours or less labels Feb 21, 2022
@github-actions

This comment was marked as outdated.

@github-actions
Copy link

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Oct 14, 2022
@github-actions
Copy link

@t-will-gillis

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 11, 2022 at 12:39 AM PST.

@t-will-gillis
Copy link
Member

Progress:
Blockers:
Availability: I have October 15-16 (Sat-Sun) free to work on this
ETA: Assuming I have no problems, by Sunday the 16th
Pictures (optional):

@t-will-gillis t-will-gillis added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Oct 15, 2022
t-will-gillis added a commit to t-will-gillis/website that referenced this issue Oct 16, 2022
@t-will-gillis
Copy link
Member

Progress: Main part complete, waiting for review
Blockers: none
Availability:
ETA: once it is reviewed...
Pictures (optional):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

3 participants