Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and fix inconsistent code indentation in a SCSS file #2695

Open
9 tasks
Tracked by #2651
SAUMILDHANKAR opened this issue Jan 18, 2022 · 1 comment
Open
9 tasks
Tracked by #2651

Identify and fix inconsistent code indentation in a SCSS file #2695

SAUMILDHANKAR opened this issue Jan 18, 2022 · 1 comment
Labels
Complexity: Medium Dependency An issue is blocking the completion or starting of another issue Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Jan 18, 2022

Dependency

Overview

As a developer, we need to make sure the code is easy to read. In this issue, we will identify and fix inconsistent indentation in _getting-started-page.scss using Lint SCSS

Action Items

  • Use the linter developed in issue Explore, document and make a new issue to implement linters which can be installed locally #2651 to identify errors in _getting-started-page.scss file in your local VS code environment
  • Make changes in the above SCSS file so that no error is displayed in your local environment
  • Review Lint SCSS and Stylelint json file
  • Make the necessary code changes (such as adding relevant indentation rules in Lint SCSS) and run the GitHub action to identify indentation errors in your own repo (Note: no errors should be displayed here as they have already been fixed once identified in the local environment)
  • Create a pull request with the right indentations in _getting-started-page.scss as well as the code changes to identify inconsistent indentation using Lint SCSS
  • Make sure the changes don't break the existing flow for other issues, such as submitting PR, merging a PR etc.

Checks

  • Make sure lines with inconsistent indentation are identified while working in your own repo:
  • Lines 172 to 199
  • Lines 285 to 297

Resources/Instructions

@SAUMILDHANKAR SAUMILDHANKAR added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1pt Can be done in 4-6 hours labels Jan 18, 2022
@github-actions
Copy link

Hi @SAUMILDHANKAR.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@JessicaLucindaCheng JessicaLucindaCheng changed the title Identify and fix inconsistent code indentation in a SCSS file DRAFT: Identify and fix inconsistent code indentation in a SCSS file Jan 18, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Identify and fix inconsistent code indentation in a SCSS file Identify and fix inconsistent code indentation in a SCSS file Jan 18, 2022
@SAUMILDHANKAR SAUMILDHANKAR added Ready for Prioritization and removed Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms labels Jan 20, 2022
@SAUMILDHANKAR SAUMILDHANKAR added the Dependency An issue is blocking the completion or starting of another issue label Feb 3, 2022
@ExperimentsInHonesty ExperimentsInHonesty added this to the 08. Team workflow milestone Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Dependency An issue is blocking the completion or starting of another issue Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

No branches or pull requests

2 participants