Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Identify and fix inconsistent code indentation in a SCSS file #2628

Closed
5 tasks
JessicaLucindaCheng opened this issue Dec 26, 2021 · 7 comments
Closed
5 tasks

DRAFT: Identify and fix inconsistent code indentation in a SCSS file #2628

JessicaLucindaCheng opened this issue Dec 26, 2021 · 7 comments
Labels
Complexity: Missing Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages size: missing
Milestone
x. Technical debt

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Dec 26, 2021 •
edited by SAUMILDHANKAR
Loading

Overview

As a developer, we need to make sure the code is easy to read. In this issue, we will identify and fix inconsistent indentation in _getting-started-page.scss using Lint SCSS

Action Items

  • Review Lint SCSS and Stylelint json file
  • Make the necessary code changes and run the GitHub action to identify indentation errors in your own repo
  • Create a pull request with the right indentations in _getting-started-page.scss as well as the code changes to identify inconsistent indentation
  • Make sure the changes don't break the existing flow for other issues, such as submitting PR, merging a PR etc.

Checks

  • Make sure lines with inconsistent indentation are identified while working in your own repo:
  • Lines 172 to 199
  • Lines 285 to 297

Resources/Instructions
@JessicaLucindaCheng JessicaLucindaCheng changed the title Code indentation is inconsistent DRAFT: Code indentation is inconsistent Dec 26, 2021
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Dec 26, 2021
@github-actions

This comment has been minimized.

Sign in to view
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Code indentation is inconsistent Code indentation is inconsistent Dec 30, 2021
@JessicaLucindaCheng JessicaLucindaCheng added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: back end/devOps Tasks for back-end developers Complexity: Medium Feature Missing This label means that the issue needs to be linked to a precise feature label. and removed role missing size: missing Feature Missing This label means that the issue needs to be linked to a precise feature label. Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages labels Dec 30, 2021
@JessicaLucindaCheng JessicaLucindaCheng changed the title Code indentation is inconsistent DRAFT: Code indentation is inconsistent Dec 30, 2021
@JessicaLucindaCheng JessicaLucindaCheng added Feature: Administrative Administrative chores etc. P-Feature: Getting Started https://www.hackforla.org/getting-started and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. Feature: Administrative Administrative chores etc. labels Dec 31, 2021
@JessicaLucindaCheng JessicaLucindaCheng added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing and removed Complexity: Medium P-Feature: Getting Started https://www.hackforla.org/getting-started labels Jan 8, 2022
@SAUMILDHANKAR SAUMILDHANKAR changed the title DRAFT: Code indentation is inconsistent DRAFT: Identify and fix inconsistent code indentation Jan 9, 2022
@SAUMILDHANKAR SAUMILDHANKAR changed the title DRAFT: Identify and fix inconsistent code indentation Identify and fix inconsistent code indentation in an SCSS file Jan 9, 2022
@SAUMILDHANKAR SAUMILDHANKAR added Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages size: 1pt Can be done in 4-6 hours and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing labels Jan 9, 2022
@SAUMILDHANKAR SAUMILDHANKAR added the Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms label Jan 9, 2022
@SAUMILDHANKAR SAUMILDHANKAR changed the title Identify and fix inconsistent code indentation in an SCSS file Identify and fix inconsistent code indentation in a SCSS file Jan 9, 2022
@JessicaLucindaCheng

This comment has been minimized.

Sign in to view
@SAUMILDHANKAR
Copy link
Member

@JessicaLucindaCheng Added an action item to ensure the changes don't break the existing flow.

@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented Jan 13, 2022 •
edited
Loading

@SAUMILDHANKAR Should this be labeled with "Dependency"? I think this issue #2651 you are drafting needs to be done first, which is installing linters locally. Then, running all the code through it locally to fix all the issues including this one. Then we could configure the linters for the repo and test out how it behaves on the repo. What do you think?

@SAUMILDHANKAR
Copy link
Member

@SAUMILDHANKAR Should this be labeled with "Dependency"? I think this issue #2651 you are drafting needs to be done first, which is installing linters locally. Then, running all the code through it locally to fix all the issues including this one. Then we could configure the linters for the repo and test out how it behaves on the repo. What do you think?

This could be done independently of #2651, so wanted to keep it separate.

Also, closing this issue as #2695 will be used to fix this (so that anyone can reach out to the author in case there are more questions)

@JessicaLucindaCheng JessicaLucindaCheng changed the title Identify and fix inconsistent code indentation in a SCSS file DRAFT: Identify and fix inconsistent code indentation in a SCSS file Jan 18, 2022
@JessicaLucindaCheng JessicaLucindaCheng removed role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1pt Can be done in 4-6 hours labels Jan 18, 2022
Open
2 tasks
This was referenced Jan 27, 2022
Closed
Open
@ExperimentsInHonesty
Copy link
Member

test

@ExperimentsInHonesty
Copy link
Member

@SAUMILDHANKAR

@Josiah-O Josiah-O added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Aug 13, 2023
@ExperimentsInHonesty ExperimentsInHonesty added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Missing Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages size: missing
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
x. Technical debt
Development

No branches or pull requests
4 participants
@SAUMILDHANKAR @JessicaLucindaCheng @ExperimentsInHonesty @Josiah-O