Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paragraph classes 1-3 to codebase #2690

Closed
13 tasks done
JessicaLucindaCheng opened this issue Jan 17, 2022 · 9 comments · Fixed by #2880
Closed
13 tasks done

Add paragraph classes 1-3 to codebase #2690

JessicaLucindaCheng opened this issue Jan 17, 2022 · 9 comments · Fixed by #2880
Assignees
Labels
Complexity: Medium Feature: Design system role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jan 17, 2022

Overview

As developers, we use reusable SCSS classes for styling Hack for LA webpages. For this issue, we will add the paragraph classes 1-3 defined in the Design System to our codebase.

Note: We will not be writing classes for paragraph classes 4-5 because the font size is illegible and should not be used on the website.

Paragraph Classes under Typography in the Design System in Figma paragraph-classes-in-design-system

Action Items

Merge Team or Technical Leads

Once the pull request associated with this issue is approved and merged, please update the following:

Resources/Instructions

@github-actions

This comment has been minimized.

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Complexity: Medium and removed size: missing role missing labels Jan 19, 2022
@JessicaLucindaCheng JessicaLucindaCheng added size: 1pt Can be done in 4-6 hours and removed size: 2pt Can be done in 7-12 hours labels Jan 21, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT-Add paragraph classes 1-3 to codebase Add paragraph classes 1-3 to codebase Jan 21, 2022
@Providence-o Providence-o added this to the y. Technical debt milestone Jan 29, 2022
@JessicaLucindaCheng JessicaLucindaCheng self-assigned this Jan 30, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Feb 4, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as outdated.

@github-actions github-actions bot added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed Status: Updated No blockers and update is ready for review labels Feb 20, 2022
@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions
Copy link

@JessicaLucindaCheng

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Thursday, February 17, 2022 at 2:43 AM PST.

@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Feb 23, 2022
@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented Feb 26, 2022

  • Progress: Coding is done and pr is opened. Fixed a typo as pointed out by Tamara.
  • Blockers: none
  • Availability: Will update later if further changes are requested
  • ETA: Will update later if further changes are requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Design system role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

2 participants