Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing text size for Getting Started page #2656

Closed
5 tasks done
SAUMILDHANKAR opened this issue Jan 4, 2022 · 8 comments · Fixed by #2988
Closed
5 tasks done

Changing text size for Getting Started page #2656

SAUMILDHANKAR opened this issue Jan 4, 2022 · 8 comments · Fixed by #2988
Assignees
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review

Comments

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Jan 4, 2022

Dependency

Overview

We need to make sure the text sizes for the header section on the Getting Started page is consistent with the rest of the site.

Action Items

  • Review the text sizes of all the project pages.
  • Change the text size of Getting Started page by using the SCSS class paragraph2 for the paragraphs in the header section so it is consistent with other project pages. (See the Paragraphs section under Typography in the Design System in Figma for how paragraph classes are defined.)
  • This issue should also address cleaning up the code in the .header-p class (where it would overlap with the properties in the paragraph2 class). Here is a link to the .header-p class:
    .header-p {
    font-size: 16px;
    font-weight: 500;
    display: flex;
    max-width: 580px;
    text-align: center;
    padding: 0 30px 10px 30px;
    // padding-bottom: 10px;
    margin: 12px auto;
    font-family: "Roboto"sans-serif;
    @media #{$bp-below-tablet} {
    font-size: 18px;
    text-align: left;
    padding: 0px;
    }
    }
  • Make sure the page looks fine for smaller viewport screens as well, such as tablet, mobile (responsiveness)

Resources/Instructions

Screenshot of the paragraph text size to be changed as per Figma

Getting started page paragraph font size

@SAUMILDHANKAR SAUMILDHANKAR added role: front end Tasks for front end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours labels Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Hi @SAUMILDHANKAR.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@SAUMILDHANKAR SAUMILDHANKAR changed the title Draft: Changing text size for Getting started page Changing text size for Getting started page Jan 7, 2022
@SAUMILDHANKAR SAUMILDHANKAR changed the title Changing text size for Getting started page Changing text size for Getting Started page Jan 7, 2022
@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added Dependency An issue is blocking the completion or starting of another issue and removed Ready for Prioritization labels Jan 16, 2022
@JessicaLucindaCheng

This comment has been minimized.

@SAUMILDHANKAR SAUMILDHANKAR added Ready for Prioritization and removed Dependency An issue is blocking the completion or starting of another issue labels Mar 3, 2022
@ExperimentsInHonesty ExperimentsInHonesty added Bug Something isn't working and removed Ready for Prioritization labels Mar 5, 2022
@A-BMT02 A-BMT02 self-assigned this Mar 14, 2022
@A-BMT02
Copy link
Member

A-BMT02 commented Mar 14, 2022

Availability: 1 hour
ETA: in 24 hours

@A-BMT02
Copy link
Member

A-BMT02 commented Mar 15, 2022

I have a blocker
How do i import the "paragraph2" class to the "getting-started" html page

Do i just give the paragragh to be changed a classname of "paragraph2" or i have to import it from the "_typography.scss"?

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 17, 2022

@A-BMT02 You don't need to import the classes because

All sass (.scss) files are imported to the main.scss file, which Jekyll processes into a single stylesheet, main.css, which defines all the styles used on the site.

For more info, see Hack for LA's Site Architecture.

So, you can add paragraph2 as a class to the starting HTML tag. For example, if I wanted to use paragraph2 class for a paragraph, I would do something like the following in the starting tag, <p class="paragraph2">.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Mar 18, 2022
@A-BMT02
Copy link
Member

A-BMT02 commented Mar 18, 2022

Noted
Thank You!

@A-BMT02
Copy link
Member

A-BMT02 commented Mar 26, 2022

Progress: Done with the checklist and awaiting final review
Blockers: No difficulties
Availability: Whole weekend
ETA: Done and awaiting review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants