Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the alt text for Citizen Engagement page images and ensure that they adhere to WCAG #2570

Closed
14 tasks done
IsaacDesigns opened this issue Dec 9, 2021 · 5 comments
Closed
14 tasks done
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: design size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review

Comments

@IsaacDesigns
Copy link
Member

IsaacDesigns commented Dec 9, 2021

Overview

We need to ensure that alt text for images adhere to Web Content Accessibility Guidelines (WCAG). For this issue, we will tackle the images under the Citizen Engagement page.

Details

Developers identified that some alt texts in the Citizen Engagement page should be reviewed because they are either inaccurate or too long. Ideally, alt text should be descriptive but short and succinct. According to the WCAG page, an accompanying alt text should be short. Additionally, the Functional Accessibility Evaluator (FAE) recommends for alt text to be no more than 100 characters.

Action Items

  • Make a copy of the tab Template [Page Name]- [Status]
  • With the copied tab replace [Page Name] with the page you are reviewing and [Status] with "Audit in Progress". Don't forget to remove brackets "[ ]"
  • Add a link of the page your working on to the Resources/Instructions section of this issue at the bottom where it says "Google sheet Tab for your page".
  • For each image on the Citizen Engagement page identify if the alt text needs to be changed, or not, using the recourses below, and fill out the google sheet. To locate the alt text use the Google Chrome browser, right click "inspect" to view pages code.
  • After completing auditing each image change your google sheet tabs [Status] to Audit Complete.
  • Review with Design Lead or another member of the team
  • Mark spreadsheet tab as QA (e.g., About Page - Audit QA)
  • Add note at bottom of issue saying its ready for QA and use the close with comment, so that it goes to the QA column

Product

  • Review the work and sign off on it if ready
    • Mark spreadsheet tab as Complete (e.g., About Page - QA Complete)
    • Add Ready for dev leads label
    • Move to New Issue Approval Column

Development

  • Create issues for that particular alt text should be created (preferably labelled good first issue) for new developers to fix
  • Close this issue

Summary

If images provide more meaning = needs alt text
If images are decorative = null alt text (alt="")

Resources/Instructions

Citizen Engagement page
Alt text decision Tree
Decorative Images and alt text
WCAG section on alt text
FAE rule 4: alt text should be less than 100 characters
Google sheet instructions
Google sheet template
Google sheet Tab for your page

@IsaacDesigns IsaacDesigns added Feature: Accessibility Issues that would broaden website accessibility role: design Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization labels Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Hi @IsaacDesigns.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@ExperimentsInHonesty ExperimentsInHonesty added this to the z. Accessibility milestone Dec 19, 2021
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement and removed Ready for Prioritization labels Dec 26, 2021
@IsaacDesigns IsaacDesigns added the size: 0.5pt Can be done in 3 hours or less label Jan 5, 2022
@jenjen26 jenjen26 self-assigned this Feb 10, 2022
@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Feb 11, 2022
@github-actions
Copy link

@jenjen26

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, February 7, 2022 at 11:17 PM PST.

@jenjen26
Copy link
Member

Blockers: None
ETA 2/24/22

@jenjen26 jenjen26 added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Feb 24, 2022
@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Apr 14, 2022
@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented May 4, 2022

Issues have been created and are being tracked in #3089, so moving this issue to done column.

@JessicaLucindaCheng
Copy link
Member

@SAUMILDHANKAR I see you have commented #2570 (comment) that you already wrote the issue. After you commented with the issue(s) you made, please remove the ready for dev leads label so we don't spend extra time checking issues that already have been followed up by a dev lead.

I will remove the label this time.

@JessicaLucindaCheng JessicaLucindaCheng removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: design size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

No branches or pull requests

5 participants