Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mobile version of new top nav #2513

Open
5 of 6 tasks
IsaacDesigns opened this issue Nov 22, 2021 · 11 comments
Open
5 of 6 tasks

Create mobile version of new top nav #2513

IsaacDesigns opened this issue Nov 22, 2021 · 11 comments
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Dependency An issue is blocking the completion or starting of another issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages p-Feature: Mobile P-Feature: Navigation role: design size: 0.5pt Can be done in 3 hours or less

Comments

@IsaacDesigns
Copy link
Member

IsaacDesigns commented Nov 22, 2021

Dependency

Overview

We need to create a mobile version of the new top nav bar so that it can be implemented and launched alongside the desktop version.

Action Items

  • Familiarize yourself with the desktop version of the site’s new top nav bar
  • Create a section to the right of the desktop version for the mobile design
  • Review the Mobile Navigation Audit in Figma to familiarize yourself with the way mobile nav is designed across the rest of the site
  • Create a design that translates the desktop version of this new menu design for mobile.
  • Ensure your design is usable and intuitive for mobile, keeps consistent with Design System guidance and other usage across the site, and provides a good experience for users.
  • Once accepted and closed, let development know to make an issue for updating the sitemap, and that they need to put it in the homepage feature branch until homepage launches.

Resources/Instructions

Figma - New Top Nav
Figma - Mobile Navigation Audit

@github-actions
Copy link

Hi @IsaacDesigns.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@AnyaStewart
Copy link
Member

The issue is awaiting review.

@IsaacDesigns
Copy link
Member Author

Looks good to me. I will send I over for Bonnie to take a look at it and let us know if the issue was completed correctly.

@ExperimentsInHonesty
Copy link
Member

@AnyaStewart Please add screen shots into the issue

@AnyaStewart
Copy link
Member

Top Nav Mobile 1212201 notes

Top Nav Mobile 1212201

@ExperimentsInHonesty
Copy link
Member

@AnyaStewart Gave notes to Isaac during meeting. Happy to talk about it directly, if you come to team meeting

  • white semi transparent background on menu does not work, with words showing through
  • The red underline seems to be new to the site, we don't do black text with red underline any place else.
  • I would like to see the other options

@AnyaStewart
Copy link
Member

@ExperimentsInHonesty Thank you for your feedback! Sunday meetings are getting hard to attend for me, but I will try to this week. My comments are in bold.

  • white semi transparent background on menu does not work, with words showing through. I agree, it was my concern as well
  • The red underline seems to be new to the site, we don't do black text with red underline any place else. It is used in the desktop version of the top nav, so I thought we might carry it over to the mobile as well? It's used a bit differently in the desktop version, so I understand if it doesn't work.
  • I would like to see the other options I showed other options to the team during our meeting and we had a vote. Attaching the screengrab with options. We decided on the Dropdown B and then I added the red color styling to it, because a chevron like that already exists in the design system. Let me know if you still want me to explore other options

Screen Shot 2022-01-06 at 10 42 02 AM

Thanks,
Anya

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Jan 7, 2022
@AnyaStewart
Copy link
Member

Update

After the Sunday meeting with here are the next steps agreed:

  1. Explore ways to incorporate the menu link turning red in a clicked state in accordance with the design system
  2. Explore the ways to show the menu links in the top nav vs links across the whole site (it's ok if it differs)
  3. Do research on the top navigation menu links: Our Work and Get in Touch have separate pages for them and the other menus links don't. How do we design it from the user perspective? (Question example: what do you expect when you see this?) @sacamp I will join the research meeting tomorrow to talk over this.

@IsaacDesigns @ExperimentsInHonesty feel free to add anything else you think is important for this issue

Thanks!
Anya

@github-actions github-actions bot added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed Status: Updated No blockers and update is ready for review labels Jan 21, 2022
@github-actions

This comment was marked as outdated.

@AnyaStewart
Copy link
Member

Progress: The issue requires research, new issue has been created for that #2686
Blockers: Research needed
Screen Shot 2022-01-21 at 1 43 38 PM
any pictures of the visual changes made to the site so far."

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks Status: Updated No blockers and update is ready for review labels Jan 28, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Feb 4, 2022
@Providence-o Providence-o added the Dependency An issue is blocking the completion or starting of another issue label Feb 6, 2022
@ExperimentsInHonesty ExperimentsInHonesty added size: 0.5pt Can be done in 3 hours or less Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks Complexity: Medium labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Dependency An issue is blocking the completion or starting of another issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages p-Feature: Mobile P-Feature: Navigation role: design size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

5 participants