Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the images on the credits page so they're all the same width #2456

Closed
3 tasks done
macho-catt opened this issue Nov 5, 2021 · 4 comments · Fixed by #2647
Closed
3 tasks done

Update the images on the credits page so they're all the same width #2456

macho-catt opened this issue Nov 5, 2021 · 4 comments · Fixed by #2647
Assignees
Labels
Complexity: Medium P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Nov 5, 2021

Overview

We need to ensure that the images on the credits page have the same width so the page looks uniform and professional.

Action Items

  • Adjust the css of the div class that contains the image (.icon-left) so the width is uniform across all images
    • Maintain a proper aspect ratio for the height
    • Adjust the image size as necessary for smaller viewport screens (responsiveness)
All individual images should be the same width

tempsnip

Resources/Instructions

Credits html file
CSS file
Credits page

@macho-catt macho-catt added role: front end Tasks for front end developers Complexity: Medium P-Feature: Credit https://www.hackforla.org/credits/ labels Nov 5, 2021
@github-actions

This comment has been minimized.

@ExperimentsInHonesty ExperimentsInHonesty changed the title Update the images on the credits page so they're all the same height Update the images on the credits page so they're all the same width Nov 21, 2021
@JimGeist JimGeist self-assigned this Dec 21, 2021
@github-actions
Copy link

@JimGeist

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, December 20, 2021 at 11:19 PM PST.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Dec 24, 2021
@ExperimentsInHonesty ExperimentsInHonesty removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Dec 26, 2021
@JimGeist
Copy link
Member

  1. Progress: I found that there is a maxwidth attribute tag. The maxwidth downsizes larger images but it does not upscale smaller images. Adding in a wdith tag for the image in the inspector console fixed the image sizes. However, not all the images will have the same 'icon' size width because some of the image files have negative space on either side of the image.
  2. Blockers: No difficulties, but I need to hold on this (2456) issue because some rework is needed for Tooltip with long text cuts off when hovering over wins icons.
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: I hope this issue (2456) and 2408 are resolved by Wednesday, Dec. 29, 2021.
  5. Pictures: No pictures at this time.

@JimGeist
Copy link
Member

  1. Progress: I found that there is a maxwidth attribute tag. The maxwidth downsizes larger images but it does not upscale smaller images. Adding in a wdith tag for the image in the inspector console fixed the image sizes. However, not all the images will have the same 'icon' size width because some of the image files have negative space on either side of the image.
  2. Blockers: None - rework for Tooltip with long text cuts off when hovering over wins icons was completed today.
  3. Availability: ~1 - 2 hours
  4. ETA: I hope this issue (2456) and 2408 are resolved by Wednesday, Dec. 29, 2021.
  5. Pictures: No pictures at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants