Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip with long text cuts off when hovering over wins icons #2408

Closed
3 tasks done
macho-catt opened this issue Oct 29, 2021 · 6 comments · Fixed by #2594 or #2713
Closed
3 tasks done

Tooltip with long text cuts off when hovering over wins icons #2408

macho-catt opened this issue Oct 29, 2021 · 6 comments · Fixed by #2594 or #2713
Assignees
Labels
Bug Something isn't working Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Milestone

Comments

@macho-catt
Copy link
Member

macho-catt commented Oct 29, 2021

Overview

We have to fix a visual bug on the wins page to present information accurately and maintain site professionalism.

Details

On the wins page, when hovering over one of the wins icons, the tooltip cuts off if the text is two lines long.

Click for example

Capture

Action Items

  • Identify what's causing the visual bug, and fix it
    • Ideally, if the line is two lines (or more) long, the tooltip shouldn't cut off with the wins cards. The tooltip should be viewed in full
  • Ensure that the fix does not break other features on the wins page

Resources/Instructions

Wins Page
Wins HTML
Wins JS
Wins CSS

@macho-catt macho-catt added Bug Something isn't working role: front end Tasks for front end developers Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ Ready for Prioritization labels Oct 29, 2021
@github-actions
Copy link

Hi @macho-catt.

Good job adding the required labels to this issue.

Additional Resources:
Wiki: How to add status labels to issues (WIP. Link will be updated when the wiki is done)
Wiki: How to create issues (WIP. Link will be updated when the wiki is done)

@JimGeist
Copy link
Member

Progress: Issue was investigated Monday night. Best fix was to change the sass settings so the bubble appears above the icons instead of below. Work was tested locally first with making changes in inspector. Changes were finalized and a pull request was made on Dec. 16, 2021.
Blockers: Conceptual first because I tried to dynamically determine the top position of the bubble using transforms. Then I realized the bottom is always the same amount above the icon.
Availability: The goal was to get it done in the week. Time in the beginning of the week was very limited.
ETA: Issue was completed Thurs. Dec. 16, 2021.
Pictures: 2408_1-After_WINS

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Dec 17, 2021
@SAUMILDHANKAR
Copy link
Member

We missed looking at the changes in responsive design mode which has some errors, so reopening this issue.

@JimGeist
Copy link
Member

Issue was revisited, fixed, and tested with desktop browser window > 960px width; desktop browser window width < 960px; responsive tablet, ipad, ipad pro and mobile phone sizes.

The display problem that caused the re-opening of the issue was addressed. When the window is not wide enough for the modal window, the WINS card is expanded to show all the WINS and text when one of the badges are clicked. The card still had the bottom: 50px; setting which caused a misalignment of the WINS badge descriptions.

@ExperimentsInHonesty
Copy link
Member

@JimGeist We are going to close the PR you made. I am sorry we were not clearer that we expected the tool tip to simply lay on top of the other assets, instead of trying to fit inside the card, which led you to think that you needed to come up with a novel solution about where to place it (which was a change that was not desired). This is a good lesson for us to be more detailed, or to provide design mockups and for you to get clarification on a design change before you start coding.

@ExperimentsInHonesty
Copy link
Member

@JimGeist Tomas indicated you had a person reason for having to jump off this ticket. I have unassigned you to spare your inbox from future work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment