Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving html files from pages/wins to _includes folder #2111

Closed
7 of 8 tasks
macho-catt opened this issue Aug 13, 2021 · 1 comment · Fixed by #2493
Closed
7 of 8 tasks

Moving html files from pages/wins to _includes folder #2111

macho-catt opened this issue Aug 13, 2021 · 1 comment · Fixed by #2493
Assignees
Labels

Comments

@macho-catt
Copy link
Member

macho-catt commented Aug 13, 2021

### Dependency
The feature branch wins-feature-1 needs to be merged first to avoid conflicts with solving this issue. Only work on this after that is done.
Specific blocking issues:
#2138
#2029
#1981
And check to see if there are any with both Wins feature label and feature branch label

Overview

As a user, I should not be able to access certain html files from the URL. (i.e. https://www.hackforla.org/pages/wins/wins-hero.html). We need to clean up how we are storing files so that they are not visible when we don't want them to be, specifically when they don't appear on the sitemap.

Details

Opened as a continuation of #2073

Jekyll should not render the individual html files under pages/wins if the main page, wins.html, already includes and renders them in its body. Additionally, a user can reach the html through the url, but this should be hidden.

Action Items

  • Create a new directory under _includes called wins-page
  • Move the following html files to _includes/wins-page
    • wins-card-template.html
    • wins-filter-template.html
    • wins-hero.html
    • wins-overlay.html
  • Edit the code for wins.html so that the liquid uses include instead of include_relative and make sure it points to the files under _include/wins-page
  • Ensure that the page still looks and functions the same way after the changes above

Note: wins.html and wins-share-form.html should stay where they are currently located

Resources/Instructions

Jekyll doc on the _includes directory
Jekyll doc on site structure
Site Architecture
Initial Issue: #2073

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 13, 2021
@macho-catt macho-catt added Feature: Infrastructure For changes on site technical architecture P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers Complexity: Medium Ready for Prioritization role: front end Tasks for front end developers Dependency An issue is blocking the completion or starting of another issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing Ready for Prioritization role: back end/devOps Tasks for back-end developers labels Aug 13, 2021
@macho-catt macho-catt removed the Dependency An issue is blocking the completion or starting of another issue label Aug 31, 2021
@macho-catt
Copy link
Member Author

After the feature branch merge, this is now ready to be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants