-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean wins.html #1981
Comments
@Abel-Zambrano Please tell me more about what this issue is about in the overview. Why is this something that needs to be done? Who does this edit serve? In what what? |
@Aveline-art This issue was actually discovered by @jbubar. I don't know the in-depth details of the issue. Hopefully he's still available and can provide more details. |
@Aveline-art I believe the idea was to convert the Google App Script array into an object with {key: value} to replace hardcoded keys in the wins.html file, lines 31-44 |
@Abel-Zambrano Can you add this information to the action items so that this can be worked on by the team? Thank you! |
@Aveline-art All done. |
@Abel-Zambrano I will also need more information on the overview and the resources to understand what the issue is about. What is the purpose of this issue? What need does this address for the team? What exactly is the context behind this task? |
@Aveline-art I apologize, I had the wrong page referenced, it's the wins.html page. I updated the issue and provided more details. The purpose is to essentially clean the page and provide cleaner code for anyone working on that file. |
Closing issue and rewriting it. Sorry @Abel-Zambrano and everyone if this was a headache. you are doing great |
Overview
Clean code on wins.html
Converting Array of Arrays (rawData) into an array of objects with {key: value} pair to remove unnecessary hard coded keys and clean the file.
Action Items
Resources/Instructions
wins.html
How To: Convert an Array into an Object
IMPORTANT!!
This issue is working off of a feature branch!
Please follow this wiki before creating a new branch!
how to work off a feature branch
The text was updated successfully, but these errors were encountered: