Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean wins.html #1981

Closed
2 tasks
Abel-Zambrano opened this issue Jul 20, 2021 · 8 comments
Closed
2 tasks

Clean wins.html #1981

Abel-Zambrano opened this issue Jul 20, 2021 · 8 comments
Assignees
Labels
Complexity: Medium Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing
Milestone

Comments

@Abel-Zambrano
Copy link
Contributor

Abel-Zambrano commented Jul 20, 2021

Overview

Clean code on wins.html

Converting Array of Arrays (rawData) into an array of objects with {key: value} pair to remove unnecessary hard coded keys and clean the file.

Action Items

  • Convert the rawData array (line 87) into an array of objects with {key: value} to replace hardcoded keys in the wins.html file (lines 31-62).
  • Remove code/notes from lines 28-62 and assure the page works as normal and nothing breaks.

Resources/Instructions

wins.html
How To: Convert an Array into an Object

IMPORTANT!!
This issue is working off of a feature branch!
Please follow this wiki before creating a new branch!
how to work off a feature branch

@Abel-Zambrano Abel-Zambrano added role: front end Tasks for front end developers Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ labels Jul 20, 2021
@ExperimentsInHonesty ExperimentsInHonesty added the Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages label Jul 25, 2021
@Aveline-art
Copy link
Member

@Abel-Zambrano Please tell me more about what this issue is about in the overview. Why is this something that needs to be done? Who does this edit serve? In what what?

@Abel-Zambrano
Copy link
Contributor Author

@Aveline-art This issue was actually discovered by @jbubar. I don't know the in-depth details of the issue. Hopefully he's still available and can provide more details.

@Abel-Zambrano
Copy link
Contributor Author

@Aveline-art I believe the idea was to convert the Google App Script array into an object with {key: value} to replace hardcoded keys in the wins.html file, lines 31-44

@Sihemgourou Sihemgourou added this to the 04. Know HFLA milestone Aug 9, 2021
@Aveline-art
Copy link
Member

@Abel-Zambrano Can you add this information to the action items so that this can be worked on by the team? Thank you!

@Abel-Zambrano
Copy link
Contributor Author

@Aveline-art All done.

@Aveline-art
Copy link
Member

Aveline-art commented Aug 11, 2021

@Abel-Zambrano I will also need more information on the overview and the resources to understand what the issue is about. What is the purpose of this issue? What need does this address for the team? What exactly is the context behind this task?

@Abel-Zambrano Abel-Zambrano changed the title Clean wins-data.json Clean wins.html Aug 12, 2021
@Abel-Zambrano
Copy link
Contributor Author

@Aveline-art I apologize, I had the wrong page referenced, it's the wins.html page. I updated the issue and provided more details. The purpose is to essentially clean the page and provide cleaner code for anyone working on that file.

@jbubar
Copy link
Member

jbubar commented Aug 20, 2021

Closing issue and rewriting it. Sorry @Abel-Zambrano and everyone if this was a headache. you are doing great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing
Projects
Development

No branches or pull requests

7 participants