Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two of the same badges appear together in the same card within the Wins Page #1911

Closed
5 tasks done
abuna1985 opened this issue Jul 9, 2021 · 6 comments · Fixed by #2214
Closed
5 tasks done

Two of the same badges appear together in the same card within the Wins Page #1911

abuna1985 opened this issue Jul 9, 2021 · 6 comments · Fixed by #2214
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review UAT: has visuals
Milestone

Comments

@abuna1985
Copy link
Member

abuna1985 commented Jul 9, 2021

Overview

We need to have unique icons for the three types of mentoring on the wins page to indicate the difference.

Action items

Development

Extra details you probably don't need to read (from before the issue was assigned to dev)

When the following wins are chosen:

  • I mentored someone on my team
  • I mentored someone on another team
  • Found a Mentor

They show the same icon. We would like to find/create new icons for 2 of these so that each win has a unique icon.

Current card with I mentored someone on my team and I mentored someone on another team

Action Items

Team discussion

  • Determine with the website dev team how feasible it is to come up with a new icon for I mentored someone on another team

Design

  • Find 2 new icons (NounProject is a good resource) in a similar style to current icons.
  • Replace old icons with new ones in this Figma frame
  • Add credit information for new icons, following the way it's listed in the green rectangle on the same Figma file.

Resources/Instructions

@abuna1985 abuna1985 added role: design P-Feature: Wins Page https://www.hackforla.org/wins/ Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Jul 9, 2021
@jbubar

This comment has been minimized.

@kristine-eudey kristine-eudey added good first issue Good for newcomers and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Jul 29, 2021
@janieche janieche self-assigned this Jul 30, 2021
@janieche
Copy link

janieche commented Jul 30, 2021

Progress: Assigned, next steps are to look for new icons and replace in Figma
Blockers: n/a
Availability: 7/30 (evening), 7/31 (morning, early afternoon), Tuesday (evening)
ETA: Wed 8/4

@janieche
Copy link

janieche commented Aug 4, 2021

Added two new mentor icons. The final version is in the yellow frame here.

@kristine-eudey
Copy link
Member

Design work has been reviewed and is ready for development. Image credit links are in green frame.

@kristine-eudey kristine-eudey added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed role: design good first issue Good for newcomers labels Aug 5, 2021
@Sihemgourou Sihemgourou added this to the 04. Know HFLA milestone Aug 9, 2021
@ExperimentsInHonesty
Copy link
Member

mentor1
mentor2

@kristine-eudey
Copy link
Member

kristine-eudey commented Aug 22, 2021

@ExperimentsInHonesty the current design with the new icons are shown in the yellow rectangle here

@abuna1985 abuna1985 added Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages and removed Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages labels Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review UAT: has visuals
Projects
Development

Successfully merging a pull request may close this issue.

8 participants