Skip to content

Commit

Permalink
Update Emergent Request issue template
Browse files Browse the repository at this point in the history
Added `ER` label
  • Loading branch information
JessicaLucindaCheng authored Jan 26, 2024
1 parent 3a2f3d9 commit 2cb09bf
Show file tree
Hide file tree
Showing 13 changed files with 26 additions and 19 deletions.
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/add-github-handle.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
name: github-handle in project file
about: 'For adding github-handle to member data in a project file'
title: 'Add github-handle for [INSERT NAME] in [INSERT PROJECT FILE]'
labels: 'P-Feature: Project Info and Page, good first issue, ready for dev lead, role: back
end/devOps, role: front end, size: 0.25pt'
about: For adding github-handle to member data in a project file
title: Add github-handle for [INSERT NAME] in [INSERT PROJECT FILE]
labels: 'good first issue, P-Feature: Project Info and Page, ready for dev lead, role:
back end/devOps, role: front end, size: 0.25pt'
assignees: ''

---
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/alt-text-audit--dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ name: Alt Text Audit - Dev
about: Developer template to update an alt text
title: "[INSERT PAGE HERE]: Update alt text for [INSERT IMAGE NAME HERE] image to
adhere to WCAG"
labels: ['Feature: Accessibility', 'good first issue', 'ready for dev lead', 'role: back end/devOps', 'role: front end', 'size: 1pt', 'Complexity: Missing']
labels: 'Complexity: Missing, Feature: Accessibility, good first issue, ready for
dev lead, role: back end/devOps, role: front end, size: 1pt'
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/creating-a-yml-file-for-a-sdg.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Creating a yml file for a SDG
about: Creating a yml file for a SDG (Sustainable Development Goal)
title: Creating a yml file for SDG [INSERT SDG NUMBER HERE]
labels: ['Complexity: Small','p-feature: SDGs','role: front end','size: 0.25pt']
labels: 'Complexity: Small, p-feature: SDGs, role: front end, size: 0.25pt'
assignees: ''

---
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/design-system-audit--text-elements.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ name: 'Design System Audit: Text Elements'
about: 'setups up and instructs how to do an audit of the text elements of a page
in Figma '
title: 'Design System Audit: Text Elements: [replace with page name] page'
labels: ['Feature Missing', 'good first issue', 'role: design', 'size: 0.25pt', 'Complexity: Missing']
labels: 'Complexity: Missing, Feature Missing, good first issue, role: design, size:
0.25pt'
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/emergent-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Emergent Request
about: When you discover something in your issue that is out of scope and it needs
a new issue or discussion
title: 'ER: [replace with info ] '
labels: 'Complexity: Missing, Feature Missing, role missing, size: 0.25pt'
labels: 'Complexity: Missing, ER, Feature Missing, role missing, size: 0.25pt'
assignees: ''

---
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/pre-work-template---design.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
name: Pre-work Template - Design
about: New Design team members should start with by making this issue for themselves.
title: 'Pre-work Checklist: Designer: [replace brackets with your name]'
labels: ['Complexity: Prework, Feature: Onboarding/Contributing.md, prework, role: design, size: 1pt']
labels: 'Complexity: Prework, Feature: Onboarding/Contributing.md, role: design, size:
1pt'
assignees: ''

---
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/pre-work-template---ux.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
name: Pre-work Template - UX
about: New Research team members should start by making this issue
title: 'Pre-work Checklist: Researcher: [replace brackets with your name]'
labels: ['Complexity: Prework, Feature: Onboarding/Contributing.md, prework, role: user research, size: 1pt']
labels: 'Complexity: Prework, Feature: Onboarding/Contributing.md, role: user research,
size: 1pt'
assignees: ''

---
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/pre-work-template--dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
name: Pre-work Template - Developers
about: New developer team members should start by making this issue for themselves
title: 'Pre-work Checklist: Developer: [replace brackets with your name]'
labels: ['Feature: Onboarding/Contributing.md', 'prework', 'size: 1pt', 'role missing', 'Complexity: Prework']
labels: 'Complexity: Prework, Feature: Onboarding/Contributing.md, role missing, size:
1pt'
assignees: ''

---
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/spell-check-audit.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: Spell check audit web page
about: 'For checking spelling on a code file that contains text displayed on the website'
title: 'Run VS Code Spell Checker on [INSERT FILE HERE]'
labels: 'Feature: Administrative, Complexity: Small, ready for dev lead, role: back
about: For checking spelling on a code file that contains text displayed on the website
title: Run VS Code Spell Checker on [INSERT FILE HERE]
labels: 'Complexity: Small, Feature: Administrative, ready for dev lead, role: back
end/devOps, role: front end, size: 0.5pt'
assignees: ''

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Suggest a feature or new content for HackforLA.org
about: Describe this issue template's purpose here.
title: ''
labels: ['enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing']
labels: 'Complexity: Missing, enhancement, Feature Missing, role missing, size: missing'
assignees: ''

---
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/suggest-a-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
name: Suggest a guide
about: 'For guides that could be helpful and listed on the toolkit page. '
title: ''
labels: ['documentation', 'enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing']
labels: 'Complexity: Missing, documentation, enhancement, Feature Missing, role missing,
size: missing'
assignees: ''

---
Expand Down
5 changes: 3 additions & 2 deletions .github/ISSUE_TEMPLATE/update-CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
---
name: Update CONTRIBUTING.md
about: 'For making updates to CONTRIBUTING.md'
about: For making updates to CONTRIBUTING.md
title: 'Update CONTRIBUTING.md Section [INSERT SECTION #]'
labels: 'Feature: Wiki, Complexity: Small, role: back end/devOps, role: front end, size: 0.5pt'
labels: 'Complexity: Small, Feature: Wiki, role: back end/devOps, role: front end,
size: 0.5pt'
assignees: ''

---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: 'Wiki: Research Plan Review: [REPLACE WITH NAME OF PAGE]'
about: Research Plan Review
title: 'Wiki: Research Plan Review: [REPLACE WITH NAME OF PAGE]'
labels: ['Feature: Wiki', 'role: user research', 'size: 0.5pt', 'Complexity: Missing']
labels: 'Complexity: Missing, Feature: Wiki, role: user research, size: 0.5pt'
assignees: sacamp

---
Expand Down

2 comments on commit 2cb09bf

@JessicaLucindaCheng
Copy link
Member Author

@JessicaLucindaCheng JessicaLucindaCheng commented on 2cb09bf Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this repo in GitHub, under "Settings" --> "Set up templates", I only manually added an ER label to the emergent-request.md issue template and made this commit directly to gh-pages using the "Propose changes" button. However, it looks like GitHub automatically changed the formatting in the fields of some of the other templates, such as remove quotation marks or brackets, re-order labels, etc. This has not happened before when I have made commits using the "Set up templates" feature in GitHub.

I took a quick preliminary look at some of the templates that were changed and they seem fine to me at first glance. However, sometime in the next few days I'll take a closer look and analyze each file that was changed to see exactly what was changed and if it impacts the way the issue template looks and functions.

@JessicaLucindaCheng
Copy link
Member Author

@JessicaLucindaCheng JessicaLucindaCheng commented on 2cb09bf Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes on the automatic changes made by GitHub:

  • Quotation marks (i.e. in .github/ISSUE_TEMPLATE/add-github-handle.md) and/or brackets (i.e. labels field in .github/ISSUE_TEMPLATE/pre-work-template---design.md) are removed from the contents in some fields. It looks like GitHub is standardizing the formatting of the contents.
  • Removed no longer existing label(s) from issue template(s). For example, label prework in .github/ISSUE_TEMPLATE/pre-work-template---design.md.
  • Changed the order of the labels (i.e. in .github/ISSUE_TEMPLATE/spell-check-audit.md).

Please sign in to comment.