Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web API Implementation for Submitting Projects #1753

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

heejung-hong
Copy link
Member

@heejung-hong heejung-hong commented Jun 20, 2024

What changes did you make?

  • Added Submitted column in projects page and dateSubmitted to the database table.

Why did you make the changes (we will use this info to test)?

  • Needed dateSubmitted to support Submitting a Project for Approval.

Issue-Specific User Account

[email protected] account was used for this issue.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes, only code.

@heejung-hong heejung-hong requested a review from entrotech June 20, 2024 06:39
Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your database migration script had a fully-qualified reference to the table, which only works in the dev environment, so I could not deploy it as-is. I modified your script slightly and included it in PR #1769 with the exact same file name. I also added a db migration script for the DRUD operations on the project table, but you will still need a new migration script for your Project_Submit stored procedure. I also rebased your branch to a more current version of the develop branch and pushed the commit back up to your PR on github. This didn't really change any of your server-side files, but did merge your client-side files with up-to-date versions from the develop branch. At this point, you should pull the branch 1704-web-api-for-submitting-project down from github and continue working on it. This branch compiles and runs on my local machine, but your new endpoint is missing the stored procedure Project_Submit, and I didn't check what parts of the Submit features work on the front-end.

@entrotech entrotech merged commit 78f8a53 into develop Aug 22, 2024
2 checks passed
@entrotech entrotech changed the title submit database migration and route Web API Implementation for Submitting Projects Aug 22, 2024
@entrotech entrotech deleted the 1704-web-api-for-submitting-project branch August 22, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Web API endpoints to support Submitting a Project for Approval
2 participants