Obsolete: Initial data migration 36 #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# ------------------------ >8 ------------------------ # Do not modify or remove the line above. # Everything below it will be ignored. # # Conflicts: # docs/CONTRIBUTING.md
alexlaw528
reviewed
Dec 2, 2023
alexlaw528
reviewed
Dec 2, 2023
alexlaw528
reviewed
Dec 2, 2023
alexlaw528
reviewed
Dec 2, 2023
alexlaw528
reviewed
Dec 2, 2023
alexlaw528
reviewed
Dec 2, 2023
| [pd-data-spreadsheet]: https://docs.google.com/spreadsheets/d/1x_zZ8JLS2hO-zG0jUocOJmX16jh-DF5dccrd_OEGNZ0/ | ||
| [apps-script]: https://thenewstack.io/how-to-convert-google-spreadsheet-to-json-formatted-text/#:~:text=To%20do%20this,%20click%20Extensions,save%20your%20work%20so%20far. | ||
|
|
||
| ## Call Script From Migration |
There was a problem hiding this comment.
Wasn't able to get this working.
Ran python manage.py migrate inside the docker container but it did not populate any information into the db
There was a problem hiding this comment.
@alexlaw528 It might have already been added to the db. Maybe try python manage.py migrate data 0001 to see if it rolls back the data. I'm not sure how to roll back past that.
alexlaw528
reviewed
Dec 2, 2023
alexlaw528
reviewed
Dec 2, 2023
alexlaw528
suggested changes
Dec 2, 2023
- removed commented out prints - improved create data with a loop - fixed docs to say 9 rows in table
…to initial-data-migration-36
…to initial-data-migration-36
ethanstrominger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
What changes did you make?
Fang - This branch is based on your branch with main merged in. Since I merged main so it is hard to compare to your branch. However, new files should be obvious. I changed convert.py so you will need to compare to yours. I also updated data guide but I want to make additonal changes if you are good with the changes I have made.
Also, somehow add-model-api-and-endpoints got conflicts which were committed. Can you fix those?
I can checkout CONTRIBUTING.md conflicts. I would like to merge this even if not perfect as long as it does not break anything that is currently working so we don't have to worry about merge conflicts.