Stakeholder details and list style improvements #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bbovenzi
commented
Oct 22, 2020
bbovenzi
commented
- no longer need to reload when changing to mobile view
- remove nested scrolling on mobile. Closes Fix nested scrolling in mobile results page #653
- remove content overlap on the details screen on iOS. Closes An issue with the full details data overlapping when viewed from the list view. #731
- details button is disabled for inactive locations
- fix filters/search padding on tablet sizes
- remove double scroll on list view or details view on mobile - fix padding on smaller desktop/tablet sizes
- remove need to refresh the page for mobile sizes - remove passing `isWindowWide` as props and some inline styles
- explicitly set flexShrink to remove overlap error in stakeholder details
- readd scroll for lists on all non mobile screens
disabled details button for inactive locations
|
Here is the scrolling right now. @pageignited does this work? or should I do the extra work to make the filters fixed at the top? |
|
@bbovenzi I think if we can have the navbar lock in place at the blue bar when a user scrolls up and then the organization scroll under, that would be best. This way, a food seeker will not have to scroll all the way back down to change a filter. |
- make search and filters sticky - reduce font size only on mobile views - fix details styling
|
@entrotech ready for review! Latest changes:
|
|
@bbovenzi Thanks |
|
@pageignited yeah, its the same behavior wherever we have the filter bar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.