Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label check updates #1555 #1592

Merged
merged 1 commit into from
Oct 8, 2024
Merged

label check updates #1555 #1592

merged 1 commit into from
Oct 8, 2024

Conversation

whitneywind
Copy link
Member

resolves #1555

  • The action will stop running if errors are encountered at any point during the action. The error will also be logged
  • I added a counter to keep track of the number of issues that labels are being added to. This counter total will be logged once it finishes
  • The success logic originally on lines 91-93 is updated to now only log about a success when it successfully adds the labels. This new logic can be seen on lines 52-55.

@whitneywind whitneywind added the ready for dev lead task ready for dev lead to evaluate label Oct 3, 2024
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitneywind Yay! Great work on this!

Just tested locally without the Github token and it exited the process as expected! 🎉

@sydneywalcoff sydneywalcoff merged commit 0211875 into dev Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants