-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1421 Fix spacing in partnership opps on mobile #1498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eburdekin! This does fix the weird mobile spacing, however the \n
was being used to help style the desktop. Can you recreate that line break using styling?
Good call @sydneywalcoff ! Updated the styling to mimic the line break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @eburdekin !
Changes look great! I have one other small thing, though.
the mobile breakpoints move the rest of the text to align left, but the partnership text stays centered. Can we have it align left with the rest of the text on the page? The title already left aligns itself.
Other than that, this looks great!
Thanks for catching @sydneywalcoff ! Fixed 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sydneywalcoff couple updates:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eburdekin Great catch! and great work on this!
Fixes #1421
Changes made:
Removed hardcoded line break in en > translation.json
Reason for changes:
Fix awkward spacing in Partnership Opportunities section of homepage on mobile