Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1421 Fix spacing in partnership opps on mobile #1498

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

eburdekin
Copy link
Member

Fixes #1421

Changes made:

Removed hardcoded line break in en > translation.json

Reason for changes:

Fix awkward spacing in Partnership Opportunities section of homepage on mobile

@eburdekin eburdekin changed the base branch from main to dev August 12, 2024 05:16
@eburdekin eburdekin added the ready for dev lead task ready for dev lead to evaluate label Aug 12, 2024
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eburdekin! This does fix the weird mobile spacing, however the \n was being used to help style the desktop. Can you recreate that line break using styling?

What it looks like on the Live site:
Screenshot 2024-08-26 at 2 20 04 PM

And your branch:
Screenshot 2024-08-26 at 2 22 47 PM

@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Aug 26, 2024
@eburdekin
Copy link
Member Author

Good call @sydneywalcoff ! Updated the styling to mimic the line break.

@eburdekin eburdekin added the ready for dev lead task ready for dev lead to evaluate label Aug 27, 2024
@sydneywalcoff sydneywalcoff self-requested a review September 9, 2024 21:19
@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Sep 9, 2024
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @eburdekin !

Changes look great! I have one other small thing, though.

the mobile breakpoints move the rest of the text to align left, but the partnership text stays centered. Can we have it align left with the rest of the text on the page? The title already left aligns itself.
Screenshot 2024-09-09 at 2 19 50 PM

Other than that, this looks great!

@eburdekin
Copy link
Member Author

Thanks for catching @sydneywalcoff ! Fixed 🫡

@sydneywalcoff sydneywalcoff self-requested a review September 17, 2024 02:56
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eburdekin Can you left align the button too? 😅

Please && thank you!

Screenshot 2024-09-16 at 7 56 43 PM

@eburdekin
Copy link
Member Author

@sydneywalcoff couple updates:

  • Re-centered body text per Figma designs
  • Changed Partnership Opportunities header to an h3 tag with different styling since the text alignment & font weight are different from the other section headers on mobile

@eburdekin eburdekin added the ready for dev lead task ready for dev lead to evaluate label Sep 17, 2024
@sydneywalcoff sydneywalcoff self-requested a review September 24, 2024 01:31
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eburdekin Great catch! and great work on this!

@sydneywalcoff sydneywalcoff merged commit 6258290 into dev Sep 24, 2024
1 check passed
@eburdekin eburdekin deleted the 1421-partnership-spacing branch September 25, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix spacing in Partnership Opportunities section of landing page on mobile
2 participants