Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1245 Input testing #1491

Merged
merged 6 commits into from
Oct 8, 2024
Merged

1245 Input testing #1491

merged 6 commits into from
Oct 8, 2024

Conversation

eburdekin
Copy link
Member

@eburdekin eburdekin commented Jul 29, 2024

Fixes #1245

Changes made:

Added tests for the following:

  • inputs render and display the correct default value
  • inputs validate responses
  • input props are passed correctly
  • inputs are accessible and focusable

Reason for changes:

We want to retroactively implement testing to better protect our codebase

@sydneywalcoff I tried setting up a jest config file to ignore these console warnings but couldn't quite figure it out. Could you help point me in the right direction?

@eburdekin eburdekin requested a review from sydneywalcoff as a code owner July 29, 2024 05:50
@eburdekin eburdekin added the ready for dev lead task ready for dev lead to evaluate label Jul 29, 2024
@eburdekin eburdekin linked an issue Aug 12, 2024 that may be closed by this pull request
16 tasks
@eburdekin
Copy link
Member Author

@sydneywalcoff figured out the config file to get the console warnings to disappear 🎉

Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eburdekin YAY! Thank you for digging around with this and figuring out a solution. I really didn't know what to do with this lol.

Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eburdekin YAY! Thank you for digging around with this and figuring out a solution. I really didn't know what to do with this lol.

lol why did this post twice

@sydneywalcoff sydneywalcoff merged commit e272683 into dev Oct 8, 2024
1 check passed
@eburdekin eburdekin deleted the 1245-input-testing branch October 8, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Testing
2 participants