Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1009 Faq Page Redesign #1028

Closed
wants to merge 6 commits into from
Closed

1009 Faq Page Redesign #1028

wants to merge 6 commits into from

Conversation

whitneywind
Copy link
Member

For issue #1009

Currently this new FAQ page has its own route and isn’t replacing the location of the FAQ page in the router, so the url to test/view it is http://localhost:3000/#/faq2. Once it’s good enough, it can easily replace the original FAQ page though.

Details:

  • The new page, FAQ2 consists of an FAQHeader component and an FAQ container component.
  • Inside the FAQ container there are three sections each with several FAQAccordion components for each question-answer pair.
  • These accordion components map through the answer’s paragraphs (in the translation.json file) to display them, though the paragraphs that contain links or bolded text are not pulled directly from the json file since they aren’t plain text.

Notes:

  • I could use another pair of eyes to help identify any spacing, stying, refactoring, or any other improvements that need to be made

Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Whitney! Thanks for this PR. I have a couple comments down below.

I love the thoughtfulness in separating the old faq and the new one. But since we're redesigning the faq, we don't need to keep the old one. Can you overwrite the faq with faq2?

For the components, the FAQAccordian, great job! Perfect.

I think the FAQHeader and FAQContainer might be a little overkill. We want our components to be reusable, and I'm not sure these will have use outside of the FAQ page. Can you refactor a little to just have these live on the FAQ page rather than in separate components? Are you able to use the ContentContainer component?

In the same line of thinking, I know design provided both mobile and desktop images for the header image. But they're not different other than size, so we can use the desktop one and have it resize responsively. Currently from ~1430px - 767px, header gets a little wonky. I'm thinking that replacing the absolute measurements with relative measurements will help. For example, the FAQDesktop image is being displayed at its intrinsic size and doesn't change as the screen gets smaller. Can you update it to get smaller as the screen gets smaller?

let me know if you have any questions!

@sydneywalcoff sydneywalcoff deleted the branch dev-old October 1, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants