Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a generated closer for the final statement #517

Closed
aahvocado opened this issue Mar 25, 2022 · 0 comments · Fixed by #534
Closed

create a generated closer for the final statement #517

aahvocado opened this issue Mar 25, 2022 · 0 comments · Fixed by #534
Assignees
@aahvocado
Labels
priority: high role: development anything related to code size: 2pt Can be done in 7-12 hours
Milestone
OGL Launch

Comments

@aahvocado
Copy link
Member

Based on discussion in https://docs.google.com/document/d/1s6BUO-mI81K7zuO_K1aEi6QMdOqpFYb6JvSv0VnWDCQ/edit# we should have a closer to sign off the letter. They suggested a list of options

Choose a closer: 
  - Sincerely,
  - Thank you for your consideration,
  - With appreciation,
  - With gratitude,
  - Thank you,
  - Thank you for your time,

and have it autofilled by user's Firstname Lastname.

Implement if we have time, otherwise just use "Sincerly, Firstname Lastname"
@aahvocado aahvocado added role: development anything related to code priority: high size: 2pt Can be done in 7-12 hours labels Mar 25, 2022
@aahvocado aahvocado self-assigned this Apr 3, 2022
@aahvocado aahvocado added this to the MVP Launch milestone Apr 3, 2022
@aahvocado aahvocado linked a pull request Apr 8, 2022 that will close this issue
#517 - add a closing statement section #534
Merged
aahvocado added a commit that referenced this issue Apr 8, 2022
@aahvocado
#517 - add a closing statement section (#534)
7db213f 
* make it so input forms are not disabled

* add Closer to FinalizeForm

* add closer to preview

* generate Closer during IntroductionPreview

* FinalizeForm.tsx - hide unused TextPreview instead of rendering null

* rename "closer" -> "closing"

* FormStateProps.ts - add closing to interface
aahvocado added a commit that referenced this issue Apr 15, 2022
@aahvocado
2022.4.14 - merge dev to master (#541)
2a79706 
* #517 - add a closing statement section (#534)

* make it so input forms are not disabled

* add Closer to FinalizeForm

* add closer to preview

* generate Closer during IntroductionPreview

* FinalizeForm.tsx - hide unused TextPreview instead of rendering null

* rename "closer" -> "closing"

* FormStateProps.ts - add closing to interface

* fix Footer causing layout issues on Mobile view (#535)

* fix Header and Footer changing sizes

* AppFooter.tsx - fix layout on mobile view

* fix buttons being invisible on bottom links

* primaryContainer: minHeight: 475px

* add Back button to Download.tsx (#536)

* #533 - update Advice page content (#537)

* translation.json - rename keys to be snake_case

* update before you begin text

* RoutingProps.ts - update before_you_begin url

* couple more minor updates to advice

* add Landing images (#538)

* delete PrimaryLandingSection.tsx

* import images for landing page

* use images and apply styles

* favicon.svg - color update to purple (#539)

* #519 - new FAQ text (#540)

* translation.json - wip content update

* apply FAQ content changes to page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aahvocado aahvocado

Labels
priority: high role: development anything related to code size: 2pt Can be done in 7-12 hours
Projects
P: EA: Project Board
Status: Done
Milestone
OGL Launch
Development

Successfully merging a pull request may close this issue.

#517 - add a closing statement section hackforla/expunge-assist
1 participant
@aahvocado