Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update generateEventData to handle daylight savings #1579

Merged
merged 2 commits into from
Feb 10, 2024
Merged

fix: Update generateEventData to handle daylight savings #1579

merged 2 commits into from
Feb 10, 2024

Conversation

trillium
Copy link
Member

Fixes #1411

What changes did you make and why did you make them ?

  • move generateEventData to its own file
  • create tests for generateEventData that cross daylight savings boundary
  • Co-authored-by: danieldkim42 [email protected]
  • No visual changes

@trillium
fix: Update generateEventData to handle daylight savings
cf0ba91 
* Move generateEventData to its own file
* Add tests for generateEventData
Co-authored-by: danieldkim42 <[email protected]>
@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Spiteless-ts.fix_timing_bug development
git pull https://github.com/Spiteless/VRMS.git ts.fix_timing_bug

@trillium trillium assigned trillium and unassigned trillium Feb 10, 2024
danieldkim42
danieldkim42 approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@danieldkim42 danieldkim42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. File changed from createRecurringEvents.js to generateEventData.js. Test file covers daylight savings and normal time checks. generateEventData now successfully checks daylight time before creating new event data

jbubar
jbubar approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still looking into this. but I wanted to approve it so that if you felt like you needed to merge it you could

@jbubar jbubar merged commit 2322f3d into hackforla:development Feb 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldkim42 danieldkim42 danieldkim42 approved these changes

@jbubar jbubar jbubar approved these changes

@bkmorgan3 bkmorgan3 Awaiting requested review from bkmorgan3

@MattPereira MattPereira Awaiting requested review from MattPereira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Users Cannot Check In
3 participants
@trillium @jbubar @danieldkim42