Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle event.date being undefined in closeCheckins #1541

Merged
merged 1 commit into from
Nov 11, 2023
Merged

fix: Handle event.date being undefined in closeCheckins #1541

merged 1 commit into from
Nov 11, 2023

Conversation

trillium
Copy link
Member

Fixes #1540

What changes did you make and why did you make them ?

  • Add if block to check if .date prop exists on events object

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Spiteless-ts.1540 development
git pull https://github.com/Spiteless/VRMS.git ts.1540

jbubar
jbubar approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I really hope this works and fixes the events bug.

@trillium trillium merged commit 23e6122 into hackforla:development Nov 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbubar jbubar jbubar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle null/undefined in closeCheckins for event.date prop
2 participants
@trillium @jbubar