Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new fields to edit project form #1527

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

bkmorgan3
Copy link
Member

Fixes #1489

What changes did you make and why did you make them ?

  • created new array in data.js representing the fields not displayed in the Model

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshot 2023-10-11 at 1 16 18 PM

@bkmorgan3 bkmorgan3 requested a review from trillium October 11, 2023 20:19
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b bkmorgan3-1489/add-all-fields development
git pull https://github.com/bkmorgan3/VRMS.git 1489/add-all-fields

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes on typos, information destructuring.

I think we also need to discuss if we want to let the user edit a field like createdDate

{
label: 'Created at',
name: 'createdAt',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, correct field name is createdDate

client/src/components/data.js Outdated Show resolved Hide resolved
@bkmorgan3
Copy link
Member Author

Requested some changes on typos, information destructuring.

I think we also need to discuss if we want to let the user edit a field like createdDate

@spiteless All things fixed. I disabled the createdDate field.

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, approved :)

@trillium trillium merged commit 65b0a03 into hackforla:development Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in all available fields from the vrms database on the project edit page
2 participants