Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create loading state for save buttons on forms related to projects #1574

Closed
5 tasks done
trillium opened this issue Feb 4, 2024 · 3 comments · Fixed by #1650
Closed
5 tasks done

Create loading state for save buttons on forms related to projects #1574

trillium opened this issue Feb 4, 2024 · 3 comments · Fixed by #1650
Assignees
@lcchrty
Labels
p-feature: API p-feature: Error Messages role: Front End size: 2pt Can be done in 7-12 hours
Milestone
04.01 Existing Fe...

Comments

@trillium
Copy link
Member

trillium commented Feb 4, 2024 •
edited by JackHaeg
Loading

Dependency

This issue should be delayed until #1576 is solved due to potential merge conflicts

Overview

Set save button to spinning loading icon while waiting for database to reply

Action Items

  • Edit ProjectForm component save button to be disabled and show a loading icon to the user.
    • Model this state off of the ReadyEvents file
    • Update submitNewProject and submitEditProject to initialized loading state when called and end loading state when returned or caught error.
  • QA
  • When complete, go to Epic: Project Edit Save #1598 and mark the checkbox referencing this issue as complete.
@trillium trillium added role: Front End size: 2pt Can be done in 7-12 hours labels Feb 4, 2024
@trillium trillium added this to the 04.01 Existing Features milestone Feb 4, 2024
This was referenced Feb 13, 2024
Open
Closed
@trillium
Copy link
Member Author

This issue should be delayed until #1576 is solved due to potential merge conflicts

@JackHaeg JackHaeg mentioned this issue Feb 15, 2024
Open
This was referenced Feb 27, 2024
Closed
Closed
@josiehandeveloper josiehandeveloper self-assigned this Mar 19, 2024
@josiehandeveloper
Copy link
Member

  1. Progress: It's in progress
  2. Blockers: I'm having trouble figuring out the logic to communicate to the backend
  3. Availability: I'll have 3 hours to work on this
  4. ETA: Hopefully soon

@JackHaeg
Copy link
Member

JackHaeg commented May 7, 2024

Unassigning for now, moving back to prioritized backlog.

@lcchrty lcchrty self-assigned this May 14, 2024
@lcchrty lcchrty mentioned this issue May 31, 2024
Merged
@JackHaeg JackHaeg moved this to In progress in P: VRMS: Project Board Jun 13, 2024
@github-project-automation github-project-automation bot moved this from In progress to Final QA (product) in P: VRMS: Project Board Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcchrty lcchrty

Labels
p-feature: API p-feature: Error Messages role: Front End size: 2pt Can be done in 7-12 hours
Projects
P: VRMS: Project Board
Status: Final QA (product)
Milestone
04.01 Existing Features
4 participants
@trillium @josiehandeveloper @lcchrty @JackHaeg