BUG: Project details are not saving

[JackHaeg]

Overview

Users are unable to edit and save Project Information with an existing project (e.g., editing the GitHub Identifier, HFLA Website URL, Google Drive URL, etc.). Currently, when a user completes all of the required fields, they receive a "Sever not responding" error message > close the project > and when they return to the project, they are presented with the old / unedited project information.

Action Items

• Check to see what the current behavior is (see below screen recording)
• Check to see if this issue is solved after completing Remove project location  #1565 (which would drop the "Location" requirement entirely)
• Ensure that users with sufficient permissions (PMs, Admins) can edit an existing project's data

Resources/Instructions

Project.Details.Issue.-.720.mov

[bkmorgan3]

@JackHaeg Tested this and the issue looks to be resolved. I was able to edit a project and it saved.

[trillium]

Sometimes the server goes down intimately and we don't really know why right now. It would be good to provide the user a better message rather than an alert box though.

[JackHaeg]

@bkmorgan3 Did you happen to test on Prod or on Dev?

• I assume this check was completed on Dev build (which does appear to save edits), however it regularly displays the error message "Wait! You made some changes. Are you sure you want to exit without saving?" the first time I go to save an edit. However, even if I click "Yes" in response, the edit is saved. @spiteless There are also additional fields available on Dev that are not available on Prod (Partners, Managed by Users, Project Status, Created Date). See below:

Screen.Recording.2024-02-01.at.4.16.02.PM.mov

• On Prod I'm still having the same issue (notice that the HFLA Website URL and GitHub Identifier are not saved after I save, close and reopen the project)

Screen.Recording.2024-02-01.at.3.56.30.PM.mov

[bkmorgan3]

Do we need to release dev to prod then? @spiteless @JackHaeg

[trillium]

Worth a check, I'll rebuild front/backend of prod now

[trillium]

Rebuilt, seems like features are saving though occasionally the reply back from the DB feels long.

@JackHaeg I believe that's what might have been happening in your video, the req is out for a long time and times out, and then is resubmitted but the server is still busy.

[JackHaeg]

@spiteless @bkmorgan3 Thanks for taking the time to make these edits. It looks like some additional fields were added & carried over (e.g., "Partners", "Managed by Users", "Project Status", and "Created Date"). I assume these are added fields that are a WIP carried over from DEV. Will confirm with the team / Bonnie what fields are necessary to include going forward.

Screenshot of additional fields

Re: the reply from the DB - let's take a look at this tonight during the All Team call. So far, I'm having a similar experience as before (edits are saved after clicking "save" > then "close", the user is presented with the warning "Wait! You made some changes. Are you sure you want to exit without saving?", even though the user has already "saved" their edits)

Screenshot of additional fields

Save.test.mov

[JackHaeg]

• Once the following issues are completed, return to this issue and check to see if the project details page is performing as expected. Issues: (Update default form values for Edit on Save so that Unsaved Changes is triggered #1576 Create loading state for save buttons on forms related to projects #1574 & Remove project input fields #1577)
  • Check if edits to project details are saving accordingly without 'unsaved changes' modal popping up (Update default form values for Edit on Save so that Unsaved Changes is triggered #1576)
  • Check if save button has a loading state (Create loading state for save buttons on forms related to projects #1574)
  • Check if added fields have been removed (Remove project input fields #1577)
  • If all of the above are accomplished, close ticket.

[JackHaeg]

• Primary issue completed, moving secondary information/issues to another epic issue: Epic: Project Edit Save #1598