Merge pull request #1434 from Spiteless/ts.vite-update-ghaction

fix: Swap to node:18.alpine, remove 'npm i- g npm'
hackforla · Jul 16, 2023 · cb810b8 · cb810b8
2 parents 86392d4 + 2fef347
commit cb810b8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/client/Dockerfile.client b/client/Dockerfile.client
@@ -1,10 +1,9 @@
-FROM node:18.12.0 AS client-development
+FROM node:18-alpine AS client-development
 RUN mkdir /srv/client && chown node:node /srv/client
 WORKDIR /srv/client
 USER node
 RUN mkdir -p node_modules
 COPY --chown=node:node package.json package.json ./
-RUN npm install -g [email protected]
 RUN npm install --silent
 
 FROM node:18.12.0-slim AS client-builder

diff --git a/client/Dockerfile.dev b/client/Dockerfile.dev
@@ -1,8 +1,7 @@
-FROM node:18.12.0 AS client-development
+FROM node:18-alpine AS client-development
 RUN mkdir /srv/client && chown node:node /srv/client
 WORKDIR /srv/client
 USER node
 RUN mkdir -p node_modules
 COPY --chown=node:node package.json package.json ./
-RUN npm install -g [email protected]
 RUN npm install --silent
diff --git a/client/Dockerfile.prod b/client/Dockerfile.prod
@@ -1,10 +1,9 @@
-FROM node:18.12.0 AS node-modules-install
+FROM node:18-alpine AS node-modules-install
 RUN mkdir /srv/client && chown node:node /srv/client
 WORKDIR /srv/client
 USER node
 RUN mkdir -p node_modules
 COPY --chown=node:node package.json package.json ./
-RUN npm install -g [email protected]
 RUN npm install --silent
 
 FROM node:18.12.0-slim AS client-builder