Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linter to docker compose dev file #587

Conversation

irais-valenzuela
Copy link
Member

@irais-valenzuela irais-valenzuela commented Sep 26, 2024

Related to #407
Just pushing to show what I did to resolve the issue that showed when I ran the docker compose build linter command on my develop branch while onboarding. It told me that it couldn't find the linter service so I added this:

 linter:
    profiles: ["lint"]
    build:  
      context: .
      dockerfile: ./dev/linter.dockerfile
    container_name: linter
    environment:
      - PRE_COMMIT_HOME=${HOME}/.cache/pre-commit
    user: ${UID}:${GID}
    env_file:
      - ./dev/linter.env
    volumes:
      - .:/src:rw
      - ${HOME}/.cache:${HOME}/.cache:rw

to thedocker-compose.dev.yml file under services. Is that the correct place to add the linter service?

@LoTerence LoTerence changed the base branch from main to develop September 27, 2024 00:26
@LoTerence
Copy link
Member

Made a note about this linter code in Issue #407. Closing this PR since its not needed anymore.

@LoTerence LoTerence closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants