Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Context for Qualifier 1 Page #502

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Created Context for Qualifier 1 Page #502

merged 4 commits into from
Feb 29, 2024

Conversation

bzzz-coding
Copy link
Member

@bzzz-coding bzzz-coding commented Feb 10, 2024 •
edited
Loading

Fixes #500

Changes

  • Designed JSON structure for COP qualifiers
  • Created context for the qualifiers/1 (COPs and roles within each COP), and refactored QualifiersPageRoles page
  • Added documentation for COP qualifiers JSON structure in mkdocs

Screenshots, if applicable

Title

@bzzz-coding bzzz-coding changed the title Refactored QualifiersPageRoles, added context, and updated documentat… Created Context for Qualifier 1 Page Feb 10, 2024
@bzzz-coding bzzz-coding marked this pull request as draft February 10, 2024 22:11
@bzzz-coding bzzz-coding marked this pull request as ready for review February 10, 2024 22:35
JimmyJuarez10
JimmyJuarez10 suggested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@JimmyJuarez10 JimmyJuarez10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really good job! Plz just try to change the structure of the json to not include any whitespace in the variable names. Its not a big deal but itll help with visibility,

mkdocs/docs/developer/frontend.md Outdated
- **COP (Community of Practice) JSON Structure:** The COP data represents different communities of practice within our organization, each consisting of various roles and descriptions. Below is the JSON structure of the COP data for QualifierPageRoles.tsx:
```
{
COPs: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the structure to not have whitespaces ? Instead of "Back End Developer" , we should use "Back_End_Developer" ... etc. plz

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JimmyJuarez10 , Thanks for your feedback! I can change the formatting in this JSON structure.
I wanted to confirm with you:
Should I also change the format of strings in frontend/src/api_data/copData.ts?
If so, that means I should replace all underscores with spaces on line 145 in frontend/src/pages/QualifierPage/QualifierPageRoles.tsx, correct? Currently, the strings are used as text values for each Chip.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm to clarify , right now we are reading the value off the chip and storing that in the json ?

@bzzz-coding bzzz-coding changed the base branch from main to develop February 20, 2024 19:21
@bzzz-coding bzzz-coding mentioned this pull request Feb 28, 2024
Closed
3 tasks
@JimmyJuarez10 JimmyJuarez10 merged commit 3aa6974 into hackforla:develop Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyJuarez10 JimmyJuarez10 Awaiting requested review from JimmyJuarez10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create React Context for Qualifier 1 Page
2 participants
@bzzz-coding @JimmyJuarez10