Adding docker tools and instructions for client side devs #854
Conversation
|
Would be great to get a review from a frontend team member. Hoping to make this as easy as possible. One outcome of this process is that we could destroy the dev environment and only stand that up when we needed to do testing as a group. |
There was a problem hiding this comment.
Hey Matt, just tried this out. Worked perfectly after deleting old docker containers with conflicting names - won't be a problem for new devs. A few small things that might make this better for any new-to-docker devs:
- Live tail the logs from the
311-apicontainer so devs can see the server running without checking running docker containers. - Instructions or a script to stop the api and cleanup containers so they aren't running forever in the background.
Other than that, this was super quick and simple. Tested calls from the docs.
client/docker/README.md
Outdated
|
|
||
| The 4 included images will need about 1 GB of space with an additional 1 GB or so needed for the data. | ||
|
|
||
| ## Initialization Script |
There was a problem hiding this comment.
What do you think about swapping the positions of Initialization Script and Installation Instructions sections? Devs (me) who don't read through the whole README first will see instructions first then an explanation of what the init script does.
There was a problem hiding this comment.
I was confused if i had to create the Initialization script myself. Would be good to just have the install instructions to make it simpler but otherwise everything works when executing the bash script. Awesome work!
Making changes to the doc and merging to get code on dev.
Includes a README and shell script to set up a local 311 Server.
All you need is to have Docker installed.